Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assuming wrong system language on macOS, fixes #11195 #11218

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

daschuer
Copy link
Member

No description provided.

@daschuer daschuer changed the base branch from main to 2.3 January 25, 2023 21:54
@daschuer daschuer added this to the 2.3.4 milestone Jan 25, 2023
@daschuer daschuer added the bug label Jan 25, 2023
src/util/translations.h Outdated Show resolved Hide resolved
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
@daschuer
Copy link
Member Author

@foss- Can you confirm that this still fixes your issue?

@foss-
Copy link
Contributor

foss- commented Jan 26, 2023

Looking good:
1

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@Swiftb0y
Copy link
Member

CI fails, didn't we fix this issue already?
https://github.com/mixxxdj/mixxx/actions/runs/4015053658/jobs/6896323968

@daschuer
Copy link
Member Author

Original the issue was not fatal, and has been merged to main only. #4824
I think we need to backport it including the follow up fix.

@Swiftb0y
Copy link
Member

Ah thanks, I'll try create a test branch with the backport (if its not too complicated).

@Swiftb0y
Copy link
Member

@foss-
Copy link
Contributor

foss- commented Jan 26, 2023

Also verified in 2.4-alpha-1407-g80fed1d8b6 (main)

@daschuer daschuer deleted the gh11195 branch May 4, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants