Mapping files for Hercules DJControl MIX

[DJPhatso]

Based on Hercules DJControl Starlight mapping released with Mixxx v2.3.0:
-Remapped LOOP and SAMPLER section according to DJControl MIX layout;
-Added Master Volume and Headphone Volume;
-Removed superfluous LED configuration (not present on DJControl MIX).

[JoergAtGithub]

The Pre-Commit check fails. You can fix this by using pre-commit.patch artifact from the CI build:
git apply pre-commit.patch
or you install pre-commit locally on your system: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking

[DJPhatso]

You can fix this by using pre-commit.patch artifact from the CI build: git apply pre-commit.patch

Not quite sure how to go about doing that.
Tried installing pre-commit locally, but it looks to be difficult with the workplace restrictions.

[JoergAtGithub]

Than download this file:

and execute
git apply pre-commit.patch

[DJPhatso]

Done.

[JoergAtGithub]

Please try again, this wasn't successful

[DJPhatso]

I re-applied the patch. Now trying to resync to commit again, but that doesn't seem to work.

[JoergAtGithub]

Please set up automaic code checking: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking

[DJPhatso]

As mentioned before, I tried these steps, but I'm doing this on my work computer, and the admin restrictions are not allowing me to install everything properly. Planning on eventually starting anew on another personal pc, but this is not possible currently.

Is there any work around ? This seems complicated just to submit a mapping.

[JoergAtGithub]

You don't need to install anything except git. Than download the pre-commit.patch from the failing GitHub build and call git apply pre-commit.patch

[DJPhatso]

If that would have worked, we wouldn't be here...

I'm in the process of installing and configuring everything as best as I can on a Linux system, and use that only for submission, but that in itself is something I could do without ATM.

[Swiftb0y]

Hey there @DJPhatso. Have you seen my PR DJPhatso#7 that fixes the pre-commit issues? If you merge that, we can start looking a more closer look at this PR. what do you think?

[DJPhatso]

Just checking if this is in-line to be included in the next release or if there is anything left to do.

[JoergAtGithub]

We need also the documentation page for the manual, see: https://github.com/mixxxdj/mixxx/wiki/Contributing-Mappings#user-content-documenting-the-mapping

[JoergAtGithub]

Overall it's looking good, but I listed some minor findings, which should be corrected before merging this.

[JoergAtGithub]

LGTM! Thank you!

[daschuer]

Hi @DJPhatso, thank you for your contribution.
It looks like we have missed to ask for your permission to distribute your code before merge. Can you catch that up, sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done? I will then put you the Mixxx 2.4 contributor list in the about box. May I use your real name?

[DJPhatso]

Filled the form, and yes, you can use my name.