Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iTunes: Fix playlist folder ordering in macOS importer #11444

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Apr 5, 2023

A small quality-of-life addition to #11353 that preserves the correct order of playlist folders imported with the macOS iTunes importer.

src/library/itunes/itunesmacosimporter.mm Outdated Show resolved Hide resolved
src/library/itunes/itunesmacosimporter.mm Outdated Show resolved Hide resolved
src/library/itunes/itunesmacosimporter.mm Outdated Show resolved Hide resolved
@fwcd fwcd force-pushed the fix-itunes-macos-folder-ordering branch from ca679da to da1a121 Compare April 17, 2023 17:23
@fwcd
Copy link
Member Author

fwcd commented Apr 17, 2023

I've implemented @Swiftb0y's suggestion to use std::multimap, which is much shorter and cleaner thanks! Also I've renamed the multimap to m_playlistDbIdsByParentDbId as suggested.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Waiting for @daschuer

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good!

@daschuer daschuer merged commit a423222 into mixxxdj:2.4 Apr 17, 2023
@fwcd fwcd deleted the fix-itunes-macos-folder-ordering branch April 17, 2023 23:01
@fwcd fwcd added the itunes label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants