Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playlists/crates: An empty search should clear the saved search text #11477

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Playlists/crates: An empty search should clear the saved search text #11477

merged 1 commit into from
Apr 13, 2023

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Apr 13, 2023

fixes #11476

@ywwg ywwg force-pushed the ywwg/searchclear branch from aa6a21f to f7ba85a Compare April 13, 2023 02:57
@ywwg ywwg changed the base branch from main to 2.4 April 13, 2023 02:57
@ywwg ywwg force-pushed the ywwg/searchclear branch from f7ba85a to 4e87138 Compare April 13, 2023 02:58
@ywwg ywwg force-pushed the ywwg/searchclear branch from 4e87138 to 4fd1679 Compare April 13, 2023 02:58
@github-actions github-actions bot added the build label Apr 13, 2023
@ywwg ywwg requested a review from daschuer April 13, 2023 03:00
daschuer
daschuer approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 260131d into mixxxdj:2.4 Apr 13, 2023
@ywwg ywwg deleted the ywwg/searchclear branch April 13, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
build controller mappings library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previous search is restored when switching crates even after search is cleared
2 participants
@ywwg @daschuer