Fix MathUtil.Denormals with clang 15/16 #11485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With -ffastmath clang format applies the flushing to zero already at the pre-processor level. This change makes sure the target does the division.
uklotzde
reviewed
Apr 17, 2023
| @@ -64,19 +64,23 @@ TEST_F(MathUtilTest, Denormal) { | |||
| _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_OFF); | |||
| _MM_SET_FLUSH_ZERO_MODE(_MM_FLUSH_ZERO_OFF); | |||
|
|
|||
| volatile float fDenormal = std::numeric_limits<float>::min() / 2.0f; | |||
| volatile float fDenormal = std::numeric_limits<float>::min(); | |||
| fDenormal /= 2.0f; | |||
There was a problem hiding this comment.
Thank you! Please add a comment why the operations are written in this style including the volatile keyword.
uklotzde
approved these changes
Apr 17, 2023
Swiftb0y
requested changes
Apr 17, 2023
src/test/mathutiltest.cpp
Outdated
Comment on lines
67
to
69
| // Note: The volatile keyword makes sure that the devision is executed on the target | ||
| // and not by the pre-processor. In case of clang >= 15 the pre-processor flushes to | ||
| // zero with -ffast-math enabled. |
There was a problem hiding this comment.
Suggested change
| // Note: The volatile keyword makes sure that the devision is executed on the target | |
| // and not by the pre-processor. In case of clang >= 15 the pre-processor flushes to | |
| // zero with -ffast-math enabled. | |
| // Note: The volatile keyword makes sure that the division is executed on the target | |
| // and not by the pre-processor. In case of clang >= 15 the pre-processor flushes to | |
| // zero with -ffast-math enabled. |
daschuer
force-pushed
the
denormals_test_fix
branch
from
cd64da9 to
c9342ec
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With -ffastmath clang format applies the flushing to zero already at the pre-processor level. This change makes sure the target does the division.
Fixes: #11484