Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing QContextMenuEvent::accept() invocations #11579

Merged
merged 1 commit into from
May 22, 2023
Merged

Add missing QContextMenuEvent::accept() invocations #11579

merged 1 commit into from
May 22, 2023

Conversation

uklotzde
Copy link
Contributor

@github-actions github-actions bot added the ui label May 22, 2023
Swiftb0y
Swiftb0y approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, currently waiting on the local compilation so I can confirm the fix to be working.

@uklotzde
Copy link
Contributor Author

This PR might not fix anything. But it establishes consistency.

@Swiftb0y
Copy link
Member

Yeah, unfortunately doesn't fix anything but lets merge regardless.

@Swiftb0y Swiftb0y merged commit 92d1457 into mixxxdj:2.3 May 22, 2023
@uklotzde uklotzde deleted the context-menu-accept branch June 4, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Swiftb0y