Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from disk: shrink dialog so buttons are (hopefully) on screen #11583

Merged
merged 1 commit into from
May 23, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 22, 2023

Make the "Remove track files from disk" dialog smaller. Track file list widget is now max 75% of screen.

That should suffice as quick fix. A more robust solution (like for the preferences) is significantly more elaborate, because IIRC the dialog needs to be shown before we can query its size and window decoration.

@ronso0 ronso0 changed the base branch from main to 2.4 May 22, 2023 21:06
@ronso0 ronso0 marked this pull request as ready for review May 22, 2023 21:06
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit bc37b30 into mixxxdj:2.4 May 23, 2023
@ronso0 ronso0 deleted the remove-from-disk-fixes branch May 23, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants