Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hid-controller-api.d.ts: Adapted the description from hidcontroller.h for parameter useNonSkippingFIFO #11664

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

JoergAtGithub
Copy link
Member

The formatting should be readable with editors that the support MarkDown in JSDoc and editors that print the text unformatted
Behavior of the parameter was changed in #11326

… useNonSkippingFIFO

The formatting should be readable with editors that the support MarkDown in JSDoc and editors that print the text unformatted
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

res/controllers/hid-controller-api.d.ts Outdated Show resolved Hide resolved
res/controllers/hid-controller-api.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@Swiftb0y Swiftb0y merged commit 29f9ec2 into mixxxdj:2.4 Jun 19, 2023
@JoergAtGithub JoergAtGithub deleted the UpdateHidApiDeclarations branch June 19, 2023 22:06
@daschuer daschuer added this to the 2.4.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants