-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use set interval setting to fix performance degration for AMD graphics adapters #11681
Conversation
Great! Thanks for all your time and persistence getting to the bottom of this! |
I have not tested it yet. But I could remember that this was a mayor issue when introducing the vsync code for waveforms. |
It's already confirmed by one of the two affected users, that this is the cause of the issue. It's easy to test, because the AMD driver allows to overwrite the setting in the application. |
Can't spot any regressions on Fedora 38 under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. do you want to squash before merging?
Ok, will do! |
… some Windows graphic adapters
3887c53
to
7697aa6
Compare
Do we still need a manual test on macOS? |
Performance seems fine to me from a quick smoke test on macOS ARM. |
Thanks for the confirmation. |
Use set interval setting to fix performance degration for AMD graphics adapters on Windows with "Wait for vertical refresh" not set to "Allways off" in the driver settings.
see: #11617 (comment)
Closes: #11617