Palesun daylight skin #11748

michelealbano · 2023-07-16T19:54:12Z

I developed a python script that visits the folders containing a skin, and re-creates in the current folder the same folder structure, copies locally the png / psd files, and for everything else it copies the files but inverts the colors.

This PR could solve issue #9217

used with skins.

Its colors are daylight-friendly.

JoergAtGithub · 2023-07-16T20:02:35Z

Why did you opened a new PR, instead of fixing the old one? This is difficult to track for reviewers.

JoergAtGithub · 2023-07-16T20:35:23Z

If pre-commit prints that it modified files, did you commit the original or the modified files? Depending on you Git client, you might need to stage them manually again.

michelealbano · 2023-07-16T20:46:43Z

I didn't know you can change the branch you commit too without creating a new PR.

…

On Sun, Jul 16, 2023 at 10:02 PM JoergAtGithub ***@***.***> wrote: Why did you opened a new PR, instead of fixing the old one? This is difficult to track for reviewers. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

daschuer · 2023-07-16T22:33:36Z

Nice. This is a good start. Thank you.

Did you do some tests under direct sunlight conditions?
I think we should do this and optimize the skin a bit.

Can we make the library text color black?

Do you also have interest to restyle the Shade library as well? The Skin itself is OK with sunlight, but the library is only barley readable.

michelealbano · 2023-07-17T00:10:45Z

I used this skin under sunlight in 3 events and it went well, I was able to see everything I needed. I have not tried it with a CDJ yet, I have a DDJ FLX4. I will take a look at the library text colors in a few weeks, after Summer vacation. Regarding the Shade skin, I tried to work on it but the color inversion made it ugly and not very usable.

…

On Mon, Jul 17, 2023 at 12:33 AM Daniel Schürmann ***@***.***> wrote: Nice. This is a good start. Thank you. Did you do some tests under direct sunlight conditions? I think we should do this and optimize the skin a bit. Can we make the library text color black? Do you also have interest to restyle the Shade library as well? The Skin itself is OK with sunlight, but the library is only barley readable. — Reply to this email directly, view it on GitHub <#11748 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC66LHEP4IJEEPMJWRM6CNLXQRT4XANCNFSM6AAAAAA2MEHCRM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

daschuer · 2023-07-17T04:53:47Z

Thank you.

For Shade I meant to just make the library brighter.

daschuer · 2023-07-17T04:58:34Z

tools/invertcolor.py

+# GNU General Public License Usage
+# This file may be used under the terms of the GNU
+# General Public License version 3 as published by the Free Software
+# Foundation. Please review the following information to
+# ensure the GNU General Public License version 3 requirements
+# will be met: https://www.gnu.org/licenses/gpl-3.0.html.
+
+__author__ = "Michele Albano"
+__copyright__ = "Copyright 2023"
+__credits__ = ["Michele Albano"]
+__license__ = "GPL"
+__version__ = "0.91"
+__maintainer__ = "Michele Albano"
+__email__ = "michele.albano@gmail.com"
+__status__ = "Prototype"


Is it possible to remove or reduce this? We normally track the copyright by the git commits and have a single License file, which is still at GPL 2.

ronso0 · 2023-07-27T12:30:57Z

res/skins/LateNight/style_palesun.qss

+  background-color: #f7f7f7;
+}
+
+#213k1, #213kCompact1, #213kMini1,


There are some strange replacements which basically eliminate a lot of styles:
#Deck > #213k
#Beat > #415t

michelealbano · 2023-07-27T12:46:02Z

Thank you for your comment. Palesun is intended to be a skin/style for people DJing under a not-so-pale sun, and I privileged function over form. I am open to suggestions, but please try out both Palesun and your modified version under the sun, to check that protecting the style does not impair vision.

…

On Thu, 27 Jul 2023, 14.31 ronso0, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In res/skins/LateNight/style_palesun.qss <#11748 (comment)>: > +* colors & icons + * font colors + * button styles + * button icons + +* library +* menu & special widget styles + + +/********************************************************************** +************** container background colors & borders *****************/ +#SkinContainer { + background-color: #f7f7f7; +} + +#213k1, #213kCompact1, #213kMini1, There are some strange replacements which basically eliminate a lot of styles: #Deck > #213k #Beat > #415t — Reply to this email directly, view it on GitHub <#11748 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC66LHDV2LSLT4GPEGG7CUTXSJNQ3ANCNFSM6AAAAAA2MEHCRM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

michelealbano · 2023-07-27T12:46:58Z

I have reduced it.

…

On Mon, 17 Jul 2023, 07.00 Daniel Schürmann, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tools/invertcolor.py <#11748 (comment)>: > +# GNU General Public License Usage +# This file may be used under the terms of the GNU +# General Public License version 3 as published by the Free Software +# Foundation. Please review the following information to +# ensure the GNU General Public License version 3 requirements +# will be met: https://www.gnu.org/licenses/gpl-3.0.html. + +__author__ = "Michele Albano" +__copyright__ = "Copyright 2023" +__credits__ = ["Michele Albano"] +__license__ = "GPL" +__version__ = "0.91" +__maintainer__ = "Michele Albano" +__email__ = ***@***.***" +__status__ = "Prototype" Is it possible to remove or reduce this? We normally track the copyright by the git commits and have a single License file, which is still at GPL 2. — Reply to this email directly, view it on GitHub <#11748 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC66LHA2B7KBSH6RQQLQZTLXQTBHRANCNFSM6AAAAAA2MEHCRM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

michelealbano · 2023-07-27T12:48:07Z

Ok I understand now what you mean, it's hilarious and I will correct that

…

On Thu, 27 Jul 2023, 14.31 ronso0, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In res/skins/LateNight/style_palesun.qss <#11748 (comment)>: > +* colors & icons + * font colors + * button styles + * button icons + +* library +* menu & special widget styles + + +/********************************************************************** +************** container background colors & borders *****************/ +#SkinContainer { + background-color: #f7f7f7; +} + +#213k1, #213kCompact1, #213kMini1, There are some strange replacements which basically eliminate a lot of styles: #Deck > #213k #Beat > #415t — Reply to this email directly, view it on GitHub <#11748 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC66LHDV2LSLT4GPEGG7CUTXSJNQ3ANCNFSM6AAAAAA2MEHCRM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

ronso0 · 2023-07-27T12:52:15Z

The script is definitly helpful for skteches, even if it has some flaws (see string replacement above).
However, plain color conversion also inverts drop shadows of containers, buttons and knobs which I don't like tbh. Fixing those manually is a lot of work, e.g. flipping the button border SVGs. It would be nice if that could be scripted, but definitly out of scope IMO. We may also make the scheme flat, i.e. ditch all 3D effects and focus more on high contrast.
For example this:

That said, if we want to add a daylight scheme I'd rather go back to the cutting table and design something new.

the tool for generating the PaleSun style for LateNight skin (invertcolor.py) was reworked, now it can correctly invert the colors

michelealbano · 2023-08-06T21:39:23Z

Ok I understand now what you mean, it's hilarious and I will correct that
…
On Thu, 27 Jul 2023, 14.31 ronso0, @.> wrote: @.* commented on this pull request. ------------------------------ In res/skins/LateNight/style_palesun.qss <#11748 (comment)>: > +* colors & icons + * font colors + * button styles + * button icons + +* library +* menu & special widget styles + + +/********************************************************************** +************** container background colors & borders **************/ +#SkinContainer { + background-color: #f7f7f7; +} + +#213k1, #213kCompact1, #213kMini1, There are some strange replacements which basically eliminate a lot of styles: #Deck > #213k #Beat > #415t — Reply to this email directly, view it on GitHub <#11748 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC66LHDV2LSLT4GPEGG7CUTXSJNQ3ANCNFSM6AAAAAA2MEHCRM . You are receiving this because you authored the thread.Message ID: @.>

I have corrected the issue raised by @ronso0 and I have already used the system in two live events. Please check it out

luzpaz · 2023-10-20T14:18:27Z

Is it possible to see more screenshots ?

Holzhaus · 2023-12-11T19:56:34Z

@luzpaz you can just download the skin and put it in your skin directory to test it yourself.

michelealbano · 2023-12-13T01:46:05Z

@luzpaz you can just download the skin and put it in your skin directory to test it yourself.

I tried to create some screenshots, but for that I updated my mixxx development branch. I am not able to compile it anymore. I use windows, and the cmake of visual studio is outdated with respect to what is required. Yes, I have just updated Visual Studio 2019, and it did not solve the issue.

I will add screenshots as soon as I find a cmake that can do the work.

daschuer · 2023-12-13T08:13:28Z

Please post the build output.
We are working hard to make everything work out of the box. Maybe something is missing for your case.

github-actions · 2024-03-17T00:08:08Z

This PR is marked as stale because it has been open 90 days with no activity.

Michele Albano added 7 commits July 16, 2023 15:34

Added a tool (intertcolor.py) to invert all the colors in a file, to be

d548aed

used with skins.

Added a skin (PaleSun) that is the inverted color version of PaleMoon.

d46da96

Its colors are daylight-friendly.

Added the generated color scheme "PaleSun" for the LateNight skin

65712c9

Added my name to skin.xml

2b0ab77

applying the coding standard to "invertcolor.py" file

8ea528a

Another try at satisfying the code standards

724ecba

changing newlines for the coding standard

5c67848

github-actions bot added the skins label Jul 16, 2023

michelealbano mentioned this pull request Jul 16, 2023

added a tool and a skin for day light #11747

Closed

pre-commit checks used

dd68799

more corrections for the coding style

fd02dcb

daschuer reviewed Jul 17, 2023

View reviewed changes

copyright etc were shortened, as suggested by daschuer

e3567ad

ronso0 reviewed Jul 27, 2023

View reviewed changes

corrected PaleSun style

813a64a

the tool for generating the PaleSun style for LateNight skin (invertcolor.py) was reworked, now it can correctly invert the colors

style corrected

345667c

This comment was marked as resolved.

Sign in to view

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Mar 17, 2024

github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Oct 25, 2024

daschuer mentioned this pull request Nov 21, 2024

(POC) add skin styles for Preferences & Track Properties, LateNight PaleMoon only #13842

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Palesun daylight skin #11748

Palesun daylight skin #11748

michelealbano commented Jul 16, 2023

JoergAtGithub commented Jul 16, 2023

JoergAtGithub commented Jul 16, 2023

michelealbano commented Jul 16, 2023 via email

daschuer commented Jul 16, 2023

michelealbano commented Jul 17, 2023 via email

daschuer commented Jul 17, 2023

daschuer Jul 17, 2023

michelealbano Jul 17, 2023

ronso0 Jul 27, 2023

michelealbano commented Jul 27, 2023 via email

michelealbano commented Jul 27, 2023 via email

michelealbano commented Jul 27, 2023 via email

ronso0 commented Jul 27, 2023

michelealbano commented Aug 6, 2023 •

edited

Loading

luzpaz commented Oct 20, 2023

This comment was marked as resolved.

Holzhaus commented Dec 11, 2023

michelealbano commented Dec 13, 2023

daschuer commented Dec 13, 2023

github-actions bot commented Mar 17, 2024

Palesun daylight skin #11748

Are you sure you want to change the base?

Palesun daylight skin #11748

Conversation

michelealbano commented Jul 16, 2023

JoergAtGithub commented Jul 16, 2023

JoergAtGithub commented Jul 16, 2023

michelealbano commented Jul 16, 2023 via email

daschuer commented Jul 16, 2023

michelealbano commented Jul 17, 2023 via email

daschuer commented Jul 17, 2023

daschuer Jul 17, 2023

Choose a reason for hiding this comment

michelealbano Jul 17, 2023

Choose a reason for hiding this comment

ronso0 Jul 27, 2023

Choose a reason for hiding this comment

michelealbano commented Jul 27, 2023 via email

michelealbano commented Jul 27, 2023 via email

michelealbano commented Jul 27, 2023 via email

ronso0 commented Jul 27, 2023

michelealbano commented Aug 6, 2023 • edited Loading

luzpaz commented Oct 20, 2023

This comment was marked as resolved.

Holzhaus commented Dec 11, 2023

michelealbano commented Dec 13, 2023

daschuer commented Dec 13, 2023

github-actions bot commented Mar 17, 2024

michelealbano commented Aug 6, 2023 •

edited

Loading