Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(effects): fix gh11808 by adding missing early return #11809

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Swiftb0y
Copy link
Member

fixes #11808.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Swiftb0y Swiftb0y added this to the 2.4.0 milestone Aug 11, 2023
@Holzhaus
Copy link
Member

Could we add a test for this? Or does this make no sense?

@Swiftb0y
Copy link
Member Author

not sure, the code is not very testable as far as I can tell.

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants