WTrackmenu: use moveToTrash() with Qt >= 5.15 #11842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Aug 27, 2023
Comment on lines
+2141
to
2144
| tr("%1 track files were moved to trash and purged " | ||
| "from the Mixxx database.") | ||
| #else | ||
| tr("%1 track files were deleted from disk and purged " |
There was a problem hiding this comment.
shouldn't this also follow the dynamic plural forms?
Suggested change
| tr("%1 track files were moved to trash and purged " | |
| "from the Mixxx database.") | |
| #else | |
| tr("%1 track files were deleted from disk and purged " | |
| tr("%n track file(s) were moved to trash and purged " | |
| "from the Mixxx database.") | |
| #else | |
| tr("%n track file(s) were deleted from disk and purged " |
There was a problem hiding this comment.
I just didn't want to touch existing tr strings to not lose the translations short before the release. Considering we drop support for Ubuntu 20.04 and can also switch to Qt 5.15 on macOS for Mixxx 2.5, I think the tr inconsistencies are okay.
|
Thank you |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.