refactor(util/timer): cleanup includes #11937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
force-pushed
the
refactor/cleanup-timer-headers
branch
from
7b806ae
to
87e24b2
Compare
Swiftb0y
force-pushed
the
refactor/cleanup-timer-headers
branch
from
87e24b2
to
dea19a3
Compare
|
Thank you! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an AutoMoc warning during the build and got annoyed by it. Turns out there was an unnecessary
#include "moc_timer.cpp". While I was at it, I also cleaned up the rest of the headers.