Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the firstSoundTest results for "Nero FAAD2 2.64" #11946

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Sep 8, 2023

This aims to fix #11940

@daschuer daschuer changed the base branch from main to 2.4 September 8, 2023 13:04
@daschuer
Copy link
Member Author

daschuer commented Sep 8, 2023

@Holzhaus: Please check if this fixes your issue on ARCH

@daschuer daschuer added this to the 2.4.0 milestone Sep 8, 2023
@Holzhaus
Copy link
Member

Holzhaus commented Sep 8, 2023

I can confirm this fixes the problem on Arch Linux. I think this will do for now, although I agree with @uklotzde's comment that these tests needs some serious rework.

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Holzhaus Holzhaus merged commit 89a1bd9 into mixxxdj:2.4 Sep 8, 2023
@daschuer
Copy link
Member Author

daschuer commented Sep 8, 2023

Which rework do you have in mind?

This test is against regressions that will happen if we change the provider or it's concrete version.
For instance it should break, when you switch from Media Foundation to FFmpeg, because they have not the same offset. We can't accept that, because it will invalidate all position dependent data stored for the tracks.

@daschuer
Copy link
Member Author

daschuer commented Sep 8, 2023

In this case using the FAAD flag is is suboptimal.
Because if the package maintainer decided to build without FAAD the test will succeed even though users have notable offsets and see the warnings about moved first sound in their logs.

However I don't see a chance to make this test aknowlege the build flags of previous builds not our under control like on ARCH. Do you have an idea how to fail in such case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoundSourceProxyTest.firstSoundTest fails on main (Arch Linux)
2 participants