EGL

[daschuer]

This brings back the GLES support required for Windows drivers that are ignored by QT and on Single PCB devices like Raspberry PI.

The spinnies are still black. #11930

Fixes #11641

[Swiftb0y]

Thank you. I'll do a manual test soon. also, iiuc this has nothing to do with EGL and is only concerning GL ES support/compatibility...

[Swiftb0y]

No regressions on fedora as far as I can tell. LGTM

[daschuer]

Thank you.

[JoergAtGithub]

I just build 2.4 and now Mixxx does no longer start up under Windows 11, when started from install directory of x64_legacy with $env:QT_OPENGL = 'angle'

warning [Main] QWindowsEGLContext: Failed to create context, eglError: 3004, this: 0x25b91296890
warning [Main] QOpenGLWindow::beginPaint: Failed to create context
warning [Main] QOpenGLWindow::beginPaint: Failed to make context current

With $env:QT_OPENGL = 'desktop' or $env:QT_OPENGL = 'software' everything works still fine using the AMD OpenGL driver.

[Swiftb0y]

Have you considered removing the QSurfaceFormat::setProfile call? The qt docs say that it'll be ignored when not supported but maybe that's broken?

[JoergAtGithub]

It seem my previous test result was not correct. I cleaned the install directory and installed again, and now get:

debug [Main] OpenGL driver version string "OpenGL ES 3.0.0 (ANGLE 2.1.5414 git hash: aa63ea230e0c)", vendor "Google Inc. (AMD)", renderer "ANGLE (AMD, AMD Radeon(TM) Graphics Direct3D11 vs_5_0 ps_5_0, D3D11-31.0.12044.50003)"
debug [Main] Supported OpenGL version: 3.0

but later it fails with:

warning [Main] QOpenGLShader::compile(Fragment): ERROR: 0:7: '0.75f' : Floating-point suffix unsupported prior to GLSL ES 3.00
ERROR: 0:7: '0.75f' : syntax error

warning [Main] *** Problematic Fragment shader source code ***
#ifdef GL_KHR_blend_equation_advanced
#extension GL_ARB_fragment_coord_conventions : enable
#extension GL_KHR_blend_equation_advanced : enable
#endif
#line 1

uniform sampler2D sampler;
uniform highp vec4 color;
varying highp vec3 vTexcoor;
void main()
{
    gl_FragColor = vec4(color.xyz, texture2D(sampler, vTexcoor.xy) * 0.75f);
}

***
DEBUG ASSERT: "addShaderFromSourceCode( GLShader::Fragment, fragmentShaderCode)" in function void __cdecl mixxx::Shader::load(const class QString &,const class QString &) at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\shaders\shader.cpp:24

[Swiftb0y]

right, thats a clearer error now at least. Can you fix the shaders locally and try again?