Better file export (rebased #3572 with Windows build fixes) #12019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* major rewrite of the export dialog * use a table to log all exported files and their errors * use template language to format the output destination * don't fail on errors, just log them * remove now obsolete export wizzard
does not require you to create a playlist for exporting files
Use a Custom Formatter to escape all tags that are not universal compatible.
And fixed Qt6 build issues
JoergAtGithub
force-pushed
the
betterfileexportqt6
branch
from
01eabea to
a3f9ab9
Compare
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a version of #3572 from @poelzi rebased to latest Main with Qt6. A PR which where the review was allready approved, but that was never merged, because the neccessary dependency Grantlee wasn't available in VCPKG.
I added the Grantlle library to VCPKG in microsoft/vcpkg#28809 therefore.
This PR contains the neccessary fixes to run on Windows now.
But unfortunatly it doesn't build on Linux anymore, because the Grantlee package in Ubuntu 22 is still build against Qt5.
There is also a build issue with macOS, but this should be just a minor CMake issue, because it compiles and links, but it doesn't find the file
libGrantlee_Templates.5.dylibduring packaging and test.I would appreciate PRs to my branch from devs on macOS and Linux, to get these two platforms building too.