Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MixxxMainWindow: Set window file path to the playing track #12116

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Oct 15, 2023

This adds a small proxy icon for the currently playing track to the title bar on platforms that support it, e.g. macOS:

Screenshot-2023-10-15-at-15 28 46

This icon can be drag-n-dropped (like a regular file) and also right-clicked to quickly access the track's parent folders:

Screenshot-2023-10-15-at-15 29 05

This adds a small proxy icon for the currently playing track that can be
drag-n-dropped to the title bar on platforms that support it.
@github-actions github-actions bot removed the ui label Oct 15, 2023
@fwcd fwcd added the ui label Oct 15, 2023
@daschuer
Copy link
Member

Is that something a user macOS user expects? Is this also implemented in other media players?

@fwcd
Copy link
Member Author

fwcd commented Oct 15, 2023

I think so, Quick Time Player definitely does (and most Cocoa apps that operate on some kind of file).

@github-actions github-actions bot removed the ui label Oct 15, 2023
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 71ac112 into mixxxdj:main Oct 15, 2023
@fwcd fwcd deleted the window-file-path branch October 16, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants