Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track table header: keep menu open after toggling a checkbox #12218

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 25, 2023

Fixes a minor annoyance when adjusting the table columns.
Adopted from Crates menu.

Columns can be toggled by clicking checkboxes or by pressing Space on a selected checkbox.
Pressing Return on a selected checkbox will toggle and close.
Clicking outside the menu will close it.

IIRC this was reported somewhere, though I didn't find a related issue.

Please verify the checkboxes look as before (i.e. no significant regressions).

@ronso0 ronso0 changed the title Track table header menu: don't close after toggling checkbox Track table header: keep menu after toggling checkbox Oct 25, 2023
@ronso0 ronso0 changed the title Track table header: keep menu after toggling checkbox Track table header: keep menu open after toggling a checkbox Dec 3, 2023
@ronso0 ronso0 force-pushed the table-header-checkboxes branch 3 times, most recently from e4dc5c3 to 1fac1cb Compare December 3, 2023 02:04
@daschuer
Copy link
Member

daschuer commented Feb 7, 2024

With this I see a bunch of warnings:

warning [Main] WTrackTableViewHeader got invalid column 1
warning [Main] WTrackTableViewHeader got invalid column 2
warning [Main] WTrackTableViewHeader got invalid column 4
warning [Main] WTrackTableViewHeader got invalid column 8
warning [Main] WTrackTableViewHeader got invalid column 10
warning [Main] WTrackTableViewHeader got invalid column 11
warning [Main] WTrackTableViewHeader got invalid column 12
warning [Main] WTrackTableViewHeader got invalid column 13
warning [Main] WTrackTableViewHeader got invalid column 14
warning [Main] WTrackTableViewHeader got invalid column 18
warning [Main] WTrackTableViewHeader got invalid column 21
warning [Main] WTrackTableViewHeader got invalid column 23
warning [Main] WTrackTableViewHeader got invalid column 24
warning [Main] WTrackTableViewHeader got invalid column 25
warning [Main] WTrackTableViewHeader got invalid column 27
warning [Main] WTrackTableViewHeader got invalid column 29

Pressing Return on a selected checkbox will toggle and close
@ronso0 ronso0 force-pushed the table-header-checkboxes branch from 1fac1cb to 944d3d3 Compare February 7, 2024 14:14
@ronso0
Copy link
Member Author

ronso0 commented Feb 7, 2024

Oh, the checkbox was added to the lookup map after toggling it (whic emits a signal).
Fixed.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good. Thank you.

@daschuer daschuer merged commit b6c409e into mixxxdj:2.4 Feb 11, 2024
14 checks passed
@ronso0 ronso0 deleted the table-header-checkboxes branch February 11, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants