Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Looping: reset loop_end_pos on eject #12224

Merged
merged 2 commits into from
Oct 28, 2023
Merged

(fix) Looping: reset loop_end_pos on eject #12224

merged 2 commits into from
Oct 28, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 26, 2023

Just a quick test if this fixes #12223
It works as expected, but let's run the tests.

In theory:
On eject, loop_in_pos was just reset (before slotLoopEndPos is called) so this eval would always be true, regardless the invalid requested loop_end_pos.
Fall through here and set loop_end_pos to -1 a few lines below.
This code hasn't changed for very long, but maybe the callers?

@ronso0 ronso0 force-pushed the looping-invalidate-end-pos-on-eject branch from 8478f29 to 7c9254b Compare October 26, 2023 23:52
@ronso0 ronso0 mentioned this pull request Oct 26, 2023
Closed
@ronso0 ronso0 marked this pull request as ready for review October 26, 2023 23:54
@ronso0 ronso0 linked an issue Oct 26, 2023 that may be closed by this pull request
"loop_end_position" does not update on eject #12223
Closed
@ronso0
Copy link
Member Author

ronso0 commented Oct 27, 2023

Existing tests passed.
I added another one for checking loop_in/_out are reset on eject.

daschuer
daschuer approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 950bac8 into mixxxdj:2.4 Oct 28, 2023
@daschuer daschuer added this to the 2.4.0 milestone Oct 28, 2023
@ronso0 ronso0 deleted the looping-invalidate-end-pos-on-eject branch October 28, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

"loop_end_position" does not update on eject
2 participants
@ronso0 @daschuer