move ordering to waveformmarkset

[m0dB]

This is a basically a code quality refactoring, but has the added bonus of fixing an inconsistency between the waveform overview and the waveform viewer.

WOverview had both a member WaveformMarkSet m_marks and a member m_marksToRender (a sorted map of the visible marks) , and code to update the second. This functionality makes more sense to live inside WaveformMarkSet.

With this refactoring, WOverview only has WaveformMarkSet m_marks, and when iteratoring over m_marks, this will be over the sorted marks to render, and WOverview doesn't need to know anything about this.

As a bonus, WaveformRenderMark, now uses the some ordering as WOverview (I believe there was a bug about this, or maybe a discussion in zulip, but I can't find it).

[m0dB]

still making some improvement post-merge.

[Swiftb0y]

fyi, a renaming is probably in order too, since mathematical sets don't have a concept of ordering...

[m0dB]

All comments have been addressed, @Swiftb0y

There is still room for more refactoring (but isn't there always 😄?) but I don't want to go there now. I left a TODO comment though.

[Swiftb0y]

also, would you mind looking into the pre-commit failure? I think its just a whitespace issue.

[m0dB]

also, would you mind looking into the pre-commit failure? I think its just a whitespace issue.

Sure, will do, though I'd like to understand how it is possible to commit things that fail, while using pre-commit locally.

DONE

[Swiftb0y]

LGTM. Thank you. I highly value your refactoring contributions.

[ronso0]

Sure, will do, though I'd like to understand how it is possible to commit things that fail, while using pre-commit locally.

Same here.
In particular I'm struggling with the qml check which sporadically finds errors in untouched qml files. Didn't find a pattern, yet.