Fix for visual waveform position while scratching outside of an activated loop #12281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the visual playposition is only done, when the engine playposition is inside the loop.
|
Thanks for this quick fix, works as desired! |
|
the code LGTM locally, though I don't understand how it relates to drag'n'drop, I'd have to reverse-engineer too much, so someone else please take a look. Thanks. |
daschuer
requested changes
Nov 17, 2023
| if ((data.m_playRate < 0.0) && (interpolatedPlayPos < data.m_loopStartPos)) { | ||
| if ((data.m_playRate < 0.0) && | ||
| (interpolatedPlayPos < data.m_loopStartPos) && | ||
| (data.m_playPos >= data.m_loopStartPos)) { |
There was a problem hiding this comment.
Please add a comment, when can this condition be false.
The same below.
daschuer
approved these changes
Nov 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12274
Add additional conditions to ensure, that loop boundary adjustment of the visual playposition is only done, when the engine playposition is inside the loop.