-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FindSleef: Use OpenMP in static builds #12295
Conversation
b369e77
to
47c06dc
Compare
Looks like we may have to do this for |
Related issue in upstream vcpkg: microsoft/vcpkg#32744 |
8a6fdce
to
941c765
Compare
set_property(TARGET rubberband::rubberband APPEND PROPERTY INTERFACE_LINK_LIBRARIES | ||
Sleef::sleef | ||
${sleefdft_path} | ||
Sleef::sleefdft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaning up this logic also has the side effect of making this dependency slightly more elegant.
97072e7
to
4b4ce35
Compare
The build went through, so I will mark this one as ready for review too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you.
Linking the vcpkg-built sleef statically on Linux seems to require OpenMP (see e.g. this build):