Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler DeckVisuals fix #12305

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Sampler DeckVisuals fix #12305

merged 4 commits into from
Nov 16, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 15, 2023

Closes #12304

info [Main] Creating skin control object: "[Sampler16],visual_bpm"
warning [Main] ControlDoublePrivate::getControl returning NULL for ( "[Sampler9]" , "end_of_track" )

Symptons were

  • no end-of-track highlight
  • no BPM display
  • no key display

for samplers requested by a skin that exceed the initial sampler count (4) or the number of samplers requested by samplers.xml

And some cleanup/tweaking en passant.

@ronso0 ronso0 linked an issue Nov 15, 2023 that may be closed by this pull request

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
after the initial samplers (default is 4), e.g. when number of samplers requested by a skin
exceeds the sampler count set by samplers.xml (0 for empty profile)
@ronso0 ronso0 force-pushed the sampler-deckvisuals-fix branch from 9001a57 to 76ea815 Compare November 15, 2023 23:51
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 1e6bb73 into mixxxdj:2.4 Nov 16, 2023
11 checks passed
@ronso0 ronso0 deleted the sampler-deckvisuals-fix branch November 16, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sampler's "end_of_track" control is not created
2 participants