Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WWaveformViewer: Fix dangling pointer access and invalid connection #12314

Merged
merged 3 commits into from
Nov 19, 2023
Merged

WWaveformViewer: Fix dangling pointer access and invalid connection #12314

merged 3 commits into from
Nov 19, 2023

Conversation

uklotzde
Copy link
Contributor

Fixes #11737.

@github-actions github-actions bot added the ui label Nov 19, 2023
Swiftb0y
Swiftb0y approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. Can you confirm the fix @JoergAtGithub?

@JoergAtGithub
Copy link
Member

I tested to change the beat grid opacity and vinyl passthrough on two decks. Works as intended!
Thank you!

@JoergAtGithub JoergAtGithub merged commit 3223a75 into mixxxdj:2.4 Nov 19, 2023
@uklotzde uklotzde deleted the wwaveformviewer branch November 19, 2023 16:13
@uklotzde
Copy link
Contributor Author

Please close the corresponding bugs manually when merging fixes.

@ronso0 ronso0 mentioned this pull request Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @JoergAtGithub @Swiftb0y