Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clamping of the index for drawing the waveform left of zero position #12411

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix clamping of the index for drawing the waveform left of zero position #12411

merged 1 commit into from
Dec 8, 2023

Conversation

m0dB
Copy link
Contributor

@m0dB m0dB commented Dec 8, 2023 •
edited
Loading

Left of the zero position was drawn was the value of the first position. I guess nobody noticed because the start of tracks tend to be low amplitude.

Before:
Screenshot 2023-12-08 at 11 15 32

After:
Screenshot 2023-12-08 at 11 49 00

@m0dB m0dB changed the base branch from main to 2.4 December 8, 2023 10:49
@JoergAtGithub
Copy link
Member

Tested on Windows11 - all fine. Code LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit b0d6d37 into mixxxdj:2.4 Dec 8, 2023
@daschuer daschuer added this to the 2.4.0 milestone Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywwg ywwg ywwg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@m0dB @JoergAtGithub @ywwg @daschuer