Increased pixmapCache size limit and made it dependent on devicePixelRatio (for HiDPI/Retina displays) #12416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ratio Moved this general definition out off coverartcache.cpp
JoergAtGithub
force-pushed
the
setProperPixmapCacheLimit
branch
from
44a2003
to
5a267c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed during profiling on Windows, that Mixxx sometimes renders SVG icons and the waveforms stuck slightly. I could fix this by increasing the pixmapCache limit for rendered SVGs and scaled CoverArt from 20MByte to 32MByte.
But these images increase all in size when HiDPI displays with higher zoom levels are used, therefore I consider this as well.
Furthermore I moved this general setting out off coverartcache.cpp.