-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skins: add skins:
path alias
#12463
Skins: add skins:
path alias
#12463
Conversation
src/skin/legacy/legacyskinparser.cpp
Outdated
// would have already triggered an error message. | ||
// Note: we may also add the user skins path, in case there are custom skins | ||
// that use the same template inheritance scheme like official skins, but we | ||
// don't because unfirtunatey there is no reliable way to apply equivalent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// don't because unfirtunatey there is no reliable way to apply equivalent | |
// don't because unfortunately there is no reliable way to apply equivalent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo, the rest LGTM Thank you.
32cc754
to
4fce12b
Compare
LGTM and works on my Windows11 system as before! Thank you! |
Thanks for testing this! |
I don't get this to run with a modded skin. Is there any further description how to use this feature? These are my steps trying to get a modded skin to run:
Now the "original" skin will be loaded instead my adapted toolbar.xml |
If you want a skin mod you need to copy only skin.xml and the (top-level) files the files to be modded. So, in your case
I agree, all in all this is still no optimal solution but IMO it's better than before. |
This is what I did. My System: Ubuntu 22.04.3 LTS |
Hmm, works nicely for me. However, there seems to be a double |
With more debug output I now see the QDir searchPaths persist, i.e. |
This fixes an inconvenience noticed by @mxmilkiib in #10123 (comment)
If you want to mod a skin that uses template urls like
skin:../Deere/some_template.xml
by copying it to the user skins directory and rename it so it's easy to identify in the skins combobox, this would break the template url scheme (requiring to alter all template urls to fix).This PR adds the system skins directory as
skins
to the QDir searchpaths for allsrc
attributes. For the plainLaunchImageStyle
stringskins:[skin name]
is resolved to the actual path.Now it's possible to locate templates via
src="skins:Deere/some_template.xml
, which in turn simplifies the process of creating simple skin mods:skin.xml
and adjust the waveform color variables for exampleThe other commits adjust Deere, LateNight and Tango to use
skins:
, and simplifies the 64-sampler templates a bit.