-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Traktor S4 Mk3] Screen support #12557
[Traktor S4 Mk3] Screen support #12557
Conversation
666b4c2
to
ca6e8cf
Compare
can you pull in the latest main changes to resolve the conflict? |
ca6e8cf
to
d834888
Compare
I think my next request would be for overview explanatory comments on all the new objects / files -- mixxx project has a bad habit of not doing code documentation and I'd like to fix that. |
d834888
to
1f3f0dc
Compare
(ah, I'm getting confused between branches, no c++ in this PR) |
1f3f0dc
to
2d831dd
Compare
@ywwg Yes, this PR is only the mapping part (QML + JS), though I can take your comment for #11407 That being said, I agree with you - enforcing code documentation would be a great thing, even for QML. I'm just not so sure how it would look like tho. But I'm keep to do some work on this, so the first QML mapping kinda set standards for future contribution |
2d831dd
to
a7f1b44
Compare
ea51a36
to
d11c916
Compare
d11c916
to
8dcc83e
Compare
8dcc83e
to
0eac4e3
Compare
Cannot be completed due to rejection of #12199 Will be kept updated in |
Per discussion, this work is not abandoned but on the back burner while we do a proper design for controller data sharing. |
This is related to PR #12259.
New mapping feature:
Depends of:
A branch with all dependencies can be used to test/use this feature while the above dependencies gets reviewed. Branch is
acolombier:traktor-s4-mk3-updated
TODO: