Track menu: order BPM action by factor, show peview (for single track) #12701
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Feb 5, 2024
|
Please explain what's not working anymore. |
|
When I click on "Halve BPM" nothing happens. Maybe this was broken before? I need to test. |
|
This seems to be an unrelated issue. I see the following console log when the beat action fails: |
daschuer
approved these changes
Feb 6, 2024
ronso0
force-pushed
the
track-menu-bpm-order-preview
branch
from
4446437 to
548dfc7
Compare
|
Done. Thanks for you review! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #10128, though that also mentions a Tap solution 🤷
No tranlation changes, can be merged any time.