[WIP] Broadcasting profiles #1278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2017 14:45
I initially forgot to add broadcastprofile.cpp into the list of source files in build/depends.py, so I didn't noticed all the errors and mistakes I've made while writing this earlier. This commit aims to fix these errors and have the BroadcastProfile class to build.
daschuer
reviewed
Jun 6, 2017
src/preferences/broadcastprofile.cpp
Outdated
|
|
||
| BroadcastProfile::BroadcastProfile(const QString& profileName) { | ||
| // TODO(Palakis, June 2nd 2017): | ||
| // Strip forbidden characters from the profile name |
There was a problem hiding this comment.
there must be a qt class that escapes user strings
added 11 commits
June 9, 2017 09:10
No idea if this works. I just want to make sure it is saved somewhere out of my computer. I may squash this with other commits later.
Both ways didn't handled the document's root tag. Now, profile values are saved properly.
|
Work for phase 1 has been slimmed down to only the XML profile subsystem, as tasks of this PR didn't focused enough on writing a good foundation for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a Work in Progress. Please do NOT merge.
This feature allows management of several sets of Live Broadcasting settings called "profiles" or "broadcasting profiles". A user can select which profile (set of server credentials, settings and encoding settings) to use when broadcasting using Mixxx.
This feature is phase 1 (out of 2) of my GSoC project for Mixxx, so the UI implemented during this phase paves the way for phase 2: multiple simultaneous broadcasting connections (a.k.a Multi-broadcasting)
More details on the project here: https://www.mixxx.org/wiki/doku.php/multi-broadcasting
Tasks:
CurrentProfilekey in mixxx.cfg referencing the name of the currently selected profile