Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences: touch multi-sampling option only with QML enabled #12794

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 12, 2024

fixup for #12546

Noticed this with #12194 being available in main, got a restart hint even though I didn't use QML.

src/preferences/dialog/dlgprefinterface.cpp Outdated Show resolved Hide resolved
src/preferences/dialog/dlgprefinterface.cpp Outdated Show resolved Hide resolved
src/preferences/constants.h Outdated Show resolved Hide resolved
src/preferences/constants.h Outdated Show resolved Hide resolved
@ronso0 ronso0 force-pushed the pref-multi-sampling branch from 8962aa6 to 45d9ec8 Compare February 12, 2024 13:34
@ronso0
Copy link
Member Author

ronso0 commented Feb 12, 2024

Thanks @Swiftb0y for your hints!

I had a feeling I shouldn't do this optimization, but I couldn't resist.
Though, I did not yet manage to make it work with your hints, I'm leaving this to others and revert this PR to the update/apply fix and the typo fix.

@ronso0 ronso0 force-pushed the pref-multi-sampling branch 2 times, most recently from 5042be7 to 45d9ec8 Compare February 12, 2024 13:42
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. I'll look into #12796

@Swiftb0y Swiftb0y merged commit 55ace25 into mixxxdj:main Feb 12, 2024
35 checks passed
@ronso0 ronso0 deleted the pref-multi-sampling branch February 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants