Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library: make 'played track color' optional #12912

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Library: make 'played track color' optional #12912

merged 1 commit into from
Mar 4, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Mar 4, 2024

Fixes #12907

@ronso0 ronso0 mentioned this pull request Mar 4, 2024
Closed
daschuer
daschuer approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as it should. Thank you.

@daschuer daschuer merged commit 113aa7d into mixxxdj:main Mar 4, 2024
13 checks passed
@daschuer daschuer added this to the 2.5-beta milestone Mar 4, 2024
@ronso0 ronso0 deleted the played-color-option branch March 4, 2024 22:21
@fwcd
Copy link
Member

fwcd commented Mar 20, 2024

This caught be a bit off-guard, thought it was a UI glitch at first... but it's a nice improvement and I appreciate it being configurable 👍

@ronso0
Copy link
Member Author

ronso0 commented Mar 20, 2024

yeah, in beta period we'll find out if the default colors work out for everyone, or if we need to make the color configurable, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
library preferences ui
Projects
None yet
Milestone
2.5-beta
Development

Successfully merging this pull request may close these issues.

Color played tracks ... invisible when working with coloured tracks
3 participants
@ronso0 @fwcd @daschuer