Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add MUSICBRAINZ flag for compiling with(out) MusicBrainz #12914

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 4, 2024

This adds the flag MUSICBRAINZ which controls whether the tag fetcher dialog and the rest of the MusicBrainz integration, including acoustic fingerprinting, is built.

This is useful, because it makes it possible to build Mixxx without Chromaprint and thus ffmpeg, which is pretty tricky to get to build for WebAssembly (the port doesn't build as-is and integrating ffmpeg.wasm seems to be nontrivial).

@fwcd fwcd added the wasm label Mar 4, 2024
@fwcd fwcd changed the title Build: Add flag for compiling with(out) MusicBrainz Build: Add MUSICBRAINZ flag for compiling with(out) MusicBrainz Mar 4, 2024
@daschuer
Copy link
Member

daschuer commented Mar 4, 2024

Uh, this clutters the code a lot. Is this only a temporary workaround? If yes, we may keep the Musikbrainz stubban only fail the chroma ID generation.

@daschuer
Copy link
Member

daschuer commented Mar 4, 2024

Alternative would be to extract the Musikbrainz classes a bit more using a proxy class or such that would also allow to use alternative implementations. (Just a rough idea) What do you think?

@fwcd
Copy link
Member Author

fwcd commented Mar 4, 2024

Great idea, I admittedly didn't really anticipate that the MusicBrainz backend was mostly coupled to the tag fetcher, so this ended up being noisier than I thought.

Would be nice to cleanly separate out the MusicBrainz part from general tag fetching (then MusicBrainz could then be moved behind a flag without cluttering the code with lots of #ifdefs in other places).

@fwcd fwcd marked this pull request as draft March 4, 2024 06:48
Copy link

github-actions bot commented Jun 3, 2024

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jun 3, 2024
@fwcd fwcd force-pushed the musicbrainz-flag branch from fba6bee to 2a71a31 Compare July 22, 2024 23:29
@fwcd fwcd removed the stale Stale issues that haven't been updated for a long time. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants