(fix) Track widgets: set show_track_menu only for main decks
#12978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
track-prop-menu-fix
branch
from
abad8e6
to
7f945c1
Compare
only for those BaseTrackPlayer created the ControlPushButtons
ronso0
force-pushed
the
track-prop-menu-fix
branch
from
7f945c1
to
238ff87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only for those BaseTrackPlayer created the ControlPushButtons.
Currently a DEBUG_ASSERT is hit if e.g. a sampler's track label receives a contextMenuEvent.
(apparently no one uses that track menu... I just discovered this by accident X)
I'd actually have pushed this minimal fix directly but a second pair of eyes would be good.