Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iTunes/Serato/Traktor/Rhythmbox: Print error if library file could not be opened #13012

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 27, 2024

Just a minor improvement of the error message to aid debugging.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@fwcd
Copy link
Member Author

fwcd commented Mar 27, 2024

Thinking about it, this would probably also be useful in the other library integrations (Traktor, Serato etc)

Edit: Done!

@fwcd fwcd changed the title ITunesXMLImporter: Print error if file could not be opened iTunes/Serato/Traktor/Rhythmbox: Print error string if db file could not be opened Mar 27, 2024
@fwcd fwcd changed the title iTunes/Serato/Traktor/Rhythmbox: Print error string if db file could not be opened iTunes/Serato/Traktor/Rhythmbox: Print error if library file could not be opened Mar 27, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 281c817 into mixxxdj:2.4 Apr 21, 2024
14 checks passed
@daschuer daschuer added this to the 2.4.1 milestone Apr 21, 2024
@fwcd fwcd deleted the itunes-error-2.4 branch April 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants