Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicks at loop-out when looping into lead-in #13294

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

daschuer
Copy link
Member

This fixes a regression from f0870ff

@ronso0
Copy link
Member

ronso0 commented May 26, 2024

Can you please provide steps to reproduce/check the fix?

Here's a commit with a comment, and another small tweak
7570cda

@daschuer
Copy link
Member Author

daschuer commented Jun 9, 2024

Here is the receipt to reproduce.

  • Use a monotone test track like a 440 Hz sine tone.
  • Create a loop starting at lead in
    -> hear the click sound at loop out. You may also record it and look at it using audacity

With this PR applied the click is smoothed out.

@ronso0
Copy link
Member

ronso0 commented Jun 20, 2024

I don't hear the clicks tbh, but I see the fading to zero.
LGTM, thanks!

@ronso0 ronso0 merged commit 985b121 into mixxxdj:2.4 Jun 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants