Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: fix font reset in multiline comment editor #13448

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 7, 2024

In the multi-line comment editor, with Qt6 and with a library font significantly taller than the default, I noticed this a few times:

  • initially the editor font is the library font (size)
  • add a line break and the editor font is reset (to app default? library default?)

I have no idea what exactly was causing this, but at least I can't reproduce anymore when adopting the library font explicitly when constructung the editor.

@ronso0 ronso0 marked this pull request as ready for review July 7, 2024 21:02
@ronso0 ronso0 added the ui label Jul 9, 2024
@ronso0 ronso0 added this to the 2.5.0 milestone Jul 9, 2024
@m0dB
Copy link
Contributor

m0dB commented Jul 13, 2024

LGTM

@m0dB m0dB merged commit f11212b into mixxxdj:2.5 Jul 13, 2024
13 checks passed
@ronso0 ronso0 deleted the lib-comment-editor-font-fix branch July 13, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants