(fix) Sound preferences: don't set m_settingsModified in update slots #13450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
soundpref-apply-keylockdualthread
branch
from
f53f991 to
c75a420
Compare
acolombier
approved these changes
Jul 8, 2024
ronso0
force-pushed
the
soundpref-apply-keylockdualthread
branch
from
c75a420 to
5321f91
Compare
|
@mixxxdj/developers This fixes an annoying bug in main, please someone take a look. |
daschuer
approved these changes
Jul 19, 2024
fwcd
reviewed
Aug 17, 2024
Comment on lines
753
to
+756
| #ifdef __RUBBERBAND__ | ||
| } | ||
|
|
||
| void DlgPrefSound::updateKeylockDualThreadingCheckbox() { |
There was a problem hiding this comment.
This #ifdef looks suspicious, does it work as intended? I'm getting some errors building for iOS (without Rubberband)...
There was a problem hiding this comment.
Seems to work, but the brace placement makes this confusing. I've fixed this and some related issues in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
m_settingsModifiedis set inDlgPrefSound::slotUpdate()which will cause a sound pause when pressing Apply in any pref page, becauseDlgPrefSound::slotApply()would reapply the current (unchanged) sound config.#13070 (comment)
Fixed by moving the keylock dual-threading checkbox update to a dedicated method and call then when necessary.
@acolombier please check if I got everything right.