Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable property editing in wtracktableview for library-redesign [library-redesign] #1347

Conversation

LindyBalboa
Copy link
Contributor

No description provided.

@LindyBalboa
Copy link
Contributor Author

Seems the build failures were not due to the code, but setting up the build environment. Could someone take a look at the build output and restart it?

@LindyBalboa LindyBalboa changed the title Re-enable property editing in wtracktableview for library-redesign Re-enable property editing in wtracktableview for library-redesign [library-redesign] Sep 26, 2017
@daschuer
Copy link
Member

Thank you for taking care of this.
The line was uncommented in this PR: jmigual#2
Unfortunately I cannot remember what was the reason.
Maybe it disabled keyboard navigation, because it eats key presses?
Could you verify this? If this is an issue we need a way around it.
(copied from daschuer#23)

@daschuer
Copy link
Member

I do not notice any regression as well. So we can merge this after we have got your permission.
LGTM

@daschuer
Copy link
Member

Thank you!

@daschuer daschuer merged commit a162054 into mixxxdj:jmigual-library-redesign Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants