Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControllerRenderingEngine: Disable BGRA when targeting Wasm #13502

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jul 22, 2024

This seems to be be unavailable when targeting WebAssembly/Emscripten, even though we already require WebGL 2.0, which is a subset of OpenGL ES 3.0:

/home/runner/work/m1xxx/m1xxx/mixxx/src/controllers/rendering/controllerrenderingengine.cpp:77:55: error: use of undeclared identifier 'GL_BGRA'
   77 |         m_GLDataFormat = m_screenInfo.reversedColor ? GL_BGRA : GL_RGBA;
      |                                                       ^
1 error generated.

Since other OpenGL ES implementations (e.g. iOS) do implement this extension, I have scoped it to non-Emscripten-platforms. Otherwise this follows the approach taken in #13382.

@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 5cbdd1d into mixxxdj:main Jul 23, 2024
13 checks passed
@fwcd fwcd deleted the disable-bgra-wasm branch July 23, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants