Fix miniscrollbar hint letters [library-redesign] #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that the `label` for the tree items did not match the `data` of the items, EXCEPT for the tracks. In the case of crates and playlists, only the `label` was the human readable version, whereas the `data` was the playlist/crate ID in the sqlite database. It could be that to enable drag/drop from the miniviews that we will need to modify the tree items in for the mini track view so that their data is also their track ID.
11 tasks
LindyBalboa
changed the title
|
That was easy! Thank you. LGTM Before merge, we need you permission. |
|
Easy to change, not easy to find! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the
labelfor the tree itemsdid not match the
dataof the items, EXCEPT for thetracks. In the case of crates and playlists, only the
labelwas the human readable version, whereas thedatawas the playlist/crate ID in the sqlite database.It could be that to enable drag/drop from the miniviews
that we will need to modify the tree items in for the
mini track view so that their data is also their track ID.