Update Linux-GitHub runner to Ubuntu 24.04.01 LTS #13781

JoergAtGithub · 2024-10-19T08:42:01Z

According our https://github.com/mixxxdj/mixxx/wiki/Minimum-requirements-policy Ubuntu 24.04.01 LTS is the earliest version, that developers need to support in new code.
I'm working on some code that fullfills this requirement, but does not build on CI, because the version of the Linux GitHub runner is lagging behind the minimum requirement. This update ensures that the CI will still pass.

I found out, that clazy version 1.11, that Ubuntu ships with 24.04.01 LTS is incompatible with the included Qt 6.4. Therfore we can't use the clazy package from the Ubuntu distribution. I added the steps to download and build it as described on the clazy homepage.

acolombier · 2024-10-19T10:34:14Z

Overall, I'm not sure this is a good idea to drop support for Ubuntu 22.04/Qt 6.2 LTS. A few reasons for that:

Ubuntu 24.04 doesn't rely on a LTS version of Qt
PopOS (which I appear to be using for full disclosure) hasn't released a 24.04 LTS due to some delay on their end

Appreciate that last point is strongly biased, but as PopOS is still fairly popular among the Linux community, so I think it would be wise to support at least, at least till we provide support for the next Qt LTS version on Linux.
Another point is, I know this is the established strategy in our wiki, but is it wise to drop support for Ubuntu LTS after only 2 years? I understand we may not want to follow precisely Canonical's strategy, but many of our Linux community relies on Ubuntu and derivatives and usually pick LTS version to ensure they won't have to break and reinstall their system every year or 2.

TL;DR is, could we support both 22.04 and 24.04, at least till we move to support the next Qt LTS version?

JoergAtGithub · 2024-10-19T10:54:31Z

* Ubuntu 24.04 doesn't rely on a LTS version of Qt

That make no difference, because 6.2 LTS and 6.4 are both out of maintenance. 6.5 is the oldes Qt6 release where bugfixes will be developed for: https://endoflife.date/qt

but is it wise to drop support for Ubuntu LTS after only 2 years?

We decided to introduce these rules, to not hinder development. Ubuntu has already very old packages, at the time of release. So we have a delay of more than 2 years until we can use upstream features.

acolombier · 2024-10-19T11:00:11Z

could we support both 22.04 and 24.04, at least till we move to support the next Qt LTS version?

How about this?

JoergAtGithub · 2024-10-19T11:14:25Z

could we support both 22.04 and 24.04, at least till we move to support the next Qt LTS version?

How about this?

This would prevent us to use new functionality.

We introduced this rule based system to give all devs predictability, and not to depend on case by case decisions with long discussions.

daschuer · 2024-10-19T13:22:34Z

We have established our Minimum-requirements-policy after exchanging quite some arguments. One major argument for me was, the desire of contributors to gain experience with bleeding etch features soon after they are available. This is "feel good" issue is important IMHO. So there is no reason to repeat this discussion.

It does on the other hand not stop us from maintaining a back port branch if there is a need for it. I am for example still at Ubuntu Focal with one of my devices to test the 2.4. branch (and urgently need to update it btw., we are beyond the deadline) and maintain such a branch: https://github.com/daschuer/mixxx/tree/focal_main.

I will do a similar branch for Ubuntu Jammy as well, that you may use as well. We may consider to make it more accessible and move it to "mixxxdj/mixxx". This is controversial of cause.

daschuer · 2024-10-19T13:24:28Z

.github/workflows/build-checks.yml

@@ -81,6 +97,7 @@ jobs:
            -DMAD=ON \
            -DMODPLUG=ON \
            -DWAVPACK=ON \
+            -DCMAKE_CXX_FLAGS="-Wno-nan-infinity-disabled" \


We should use our fpclassify.cpp instead.

This is not a regression of this PR, as the check hasn't existed before. Therefore it's out of scope of this PR!

Yes, but let's keep the warning until the issue is fixed in the other PR.

But than all CI runs fail?

Opened a new issue, so that we don't we forget about it: #13837

Problem solved?

daschuer · 2024-10-19T13:28:23Z

.github/workflows/build-checks.yml

    name: ${{ matrix.name }}
    steps:
      - name: Check out repository
        uses: actions/checkout@v4.2.1
      - name: Install build dependencies
        run: tools/debian_buildenv.sh setup
+      - name: Build clazy v1.12
+        if: matrix.name == 'clazy'
+        # Ubuntu2404 comes with v1.11, which is too old for the Qt6.4 shipped with Ubuntu 2404


Do we have a reference for this, a Mixxx and a Ubuntu bug? This sounds like an issue we should solve in our https://github.com/daschuer/mixxx/blob/focal_main/tools/debian_buildenv.sh instead.

I could move it to debian_buildenv.sh, but than clazy would be always build and not only for the clazy CI action.

The goal should be to have a working clazy locally by default. I looked around to find a PPA for that but not yet found. Maybe we add this to our Launchpad PPA? What is the issue you trying to solve btw.?

It can not compile the Qt6.4 headers, because of unsupported C++ features

This takes 5 min. A bit long IMHO.
With a bit of luck the Ocular version will work: https://packages.ubuntu.com/oracular/clazy

using the Oracular build works

echo "deb http://archive.ubuntu.com/ubuntu oracular main universe" | sudo tee /etc/apt/sources.list.d/oracular-temp.list echo -e "Package: *\nPin: release n=oracular\nPin-Priority: 100" | sudo tee /etc/apt/preferences.d/oracular.pref sudo apt update sudo apt install -t oracular clazy

Penalty 46s

The Oracular hack updates a lot of dependency. Nothing I would like to do at home.

The macOS solution sounds promising. It looks like macOS builds are in general faster so it is probably a win-win.

macOS is not the way to go, the Homebrew installation of Clazy took 1h 50m 50s because it builds the whole llvm package as dependency.

Oh, that's bad. So we have two remaining options. Push the clazy build to our PPA, or make use of the GitHub cache. I will look in the PPA solution. It should be straight forward using the Oracular rule file. This has the benefit that Ubuntu users can use it at home as well.

We've also the docker container solution proposed by Jan as third option. But I'm also in favor to trying the PPA solution first, as it covers not only CI.

.github/workflows/build-checks.yml

…f QQmlEngine

…ecessary

…ere necessary

daschuer · 2024-11-04T21:45:42Z

src/qml/qmlchainpresetmodel.h

@@ -1,6 +1,6 @@
 #pragma once
 #include <QAbstractListModel>
-#include <QtQml>
+#include <QQmlEngine>


This is also out of scope of this PR.

This is necessary, that Clazy passes, should I move it to an own PR?

It is not very important. I actually prefere to have everything fixed either in one go or before doing the switch. This as well as the nan-infinity-disabled issue. We need to do it anyway at one point, let's avoid intermediate workarounds.

daschuer · 2024-11-08T23:39:54Z

JoergAtGithub#2
Contains the new clazy and the infinity fix.
It was not the upload no brainer I have first thought because of failing test with the older Qt version. But now everything is in shape. .. hopefully.

…lazy runner

JoergAtGithub · 2024-11-10T20:01:14Z

This is ready for merge now:

@daschuer set up the Clazy 1.12 PPA, which works great!
The last remaining Clazy error is fixed in this PR
The new default clang-tidy check for "use of infinity" with fast-math (see Use of infinity() in code compiled with -ffast-math ( durationutiltest.cpp & frametest.cpp ) #13780 for details) remains disabled as before -> This is no regression!

Swiftb0y · 2024-11-10T21:00:08Z

.github/workflows/build-checks.yml

@@ -81,6 +90,7 @@ jobs:
            -DMAD=ON \
            -DMODPLUG=ON \
            -DWAVPACK=ON \
+            -DCMAKE_CXX_FLAGS="-Wno-nan-infinity-disabled" \


could you add a comment at the issue locations so we don't forget to remove this line once fixed?

daschuer

LGTM, Thank you.

daschuer · 2024-11-10T23:06:07Z

Unfortunately we have a conflict now.

…Wno-nan-infinity-disabled when the issue is fixed

JoergAtGithub · 2024-11-11T18:29:58Z

I fixed the merge-conflict and added the comments suggested by Niko.

daschuer · 2024-11-11T18:40:21Z

Thank you.

Swiftb0y · 2024-11-11T19:43:17Z

.pre-commit-config.yaml

-    rev: 37c2513b1b8275a475a160ed2f5b044910335d5f # No release tag yet including #6 fix
+    rev: latest # No release tag yet including #6 fix


this should be reverted... pre-commit does that automatically unfortunately when running autoupdate.

I opened PR #13880, which reverts this unintended change.

JoergAtGithub added 2 commits October 18, 2024 17:51

Update runner for Linux build to Ubuntu 24.04.01 LTS

0bde346

Update build-checks to Ubuntu 24.04.01 LTS and use Clazy v1.12

257488d

daschuer requested changes Oct 19, 2024

View reviewed changes

JoergAtGithub added 7 commits October 20, 2024 09:11

Reduced include scope from module include of QtQml by class include o…

692c64e

…f QQmlEngine

Enable clazy module include check

658faa7

Removed module wide include of QtSql and added class includes where n…

a837df6

…ecessary

Removed module wide include of QtConcurrent and added sub includes wh…

e487fc4

…ere necessary

Merge remote-tracking branch 'upstream/main' into ubuntu_240401

aef67fa

Removed module wide include of QtDbus and added class includes instead

2f3f826

Merge remote-tracking branch 'upstream/main' into ubuntu_240401

57c09d9

github-actions bot added the qml label Nov 4, 2024

JoergAtGithub requested a review from daschuer November 4, 2024 19:38

daschuer reviewed Nov 4, 2024

View reviewed changes

Holzhaus mentioned this pull request Nov 4, 2024

Fix -Wnan-infinity-disabled warnings with new clang-tidy #13837

Open

Add clazy PPA to work around the outdated clazy 1.11 version

46d98ad

JoergAtGithub force-pushed the ubuntu_240401 branch from 80240dc to 22fb1c5 Compare November 10, 2024 17:32

Restore lost clazy version printout, and only install clazy for the c…

aa05940

…lazy runner

JoergAtGithub force-pushed the ubuntu_240401 branch from 22fb1c5 to aa05940 Compare November 10, 2024 17:46

JoergAtGithub mentioned this pull request Nov 10, 2024

Infinity fix and clang from PPA JoergAtGithub/mixxx#2

Closed

JoergAtGithub requested a review from daschuer November 10, 2024 19:55

Swiftb0y reviewed Nov 10, 2024

View reviewed changes

daschuer approved these changes Nov 10, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into ubuntu_240401

3a58cd0

github-actions bot added the code quality label Nov 11, 2024

Add comments at the issue locations, that we don't forget to remove -…

4142e7f

…Wno-nan-infinity-disabled when the issue is fixed

daschuer merged commit c39cc5f into mixxxdj:main Nov 11, 2024
13 checks passed

JoergAtGithub deleted the ubuntu_240401 branch November 11, 2024 18:43

Swiftb0y reviewed Nov 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Linux-GitHub runner to Ubuntu 24.04.01 LTS #13781

Update Linux-GitHub runner to Ubuntu 24.04.01 LTS #13781

JoergAtGithub commented Oct 19, 2024

acolombier commented Oct 19, 2024 •

edited

Loading

JoergAtGithub commented Oct 19, 2024

acolombier commented Oct 19, 2024

JoergAtGithub commented Oct 19, 2024

daschuer commented Oct 19, 2024

daschuer Oct 19, 2024

JoergAtGithub Nov 4, 2024

daschuer Nov 4, 2024

JoergAtGithub Nov 4, 2024

Holzhaus Nov 4, 2024

daschuer Oct 19, 2024

JoergAtGithub Oct 20, 2024

daschuer Oct 20, 2024

JoergAtGithub Oct 20, 2024

daschuer Nov 4, 2024

daschuer Nov 5, 2024 •

edited

Loading

daschuer Nov 5, 2024

JoergAtGithub Nov 5, 2024

daschuer Nov 6, 2024

JoergAtGithub Nov 6, 2024

daschuer Nov 4, 2024

JoergAtGithub Nov 4, 2024

daschuer Nov 5, 2024

daschuer commented Nov 8, 2024

JoergAtGithub commented Nov 10, 2024

Swiftb0y Nov 10, 2024 •

edited

Loading

daschuer left a comment

daschuer commented Nov 10, 2024

JoergAtGithub commented Nov 11, 2024

daschuer commented Nov 11, 2024

Swiftb0y Nov 11, 2024

JoergAtGithub Nov 11, 2024

		rev: 37c2513b1b8275a475a160ed2f5b044910335d5f # No release tag yet including #6 fix
		rev: latest # No release tag yet including #6 fix

Update Linux-GitHub runner to Ubuntu 24.04.01 LTS #13781

Update Linux-GitHub runner to Ubuntu 24.04.01 LTS #13781

Conversation

JoergAtGithub commented Oct 19, 2024

acolombier commented Oct 19, 2024 • edited Loading

JoergAtGithub commented Oct 19, 2024

acolombier commented Oct 19, 2024

JoergAtGithub commented Oct 19, 2024

daschuer commented Oct 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daschuer Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daschuer commented Nov 8, 2024

JoergAtGithub commented Nov 10, 2024

Swiftb0y Nov 10, 2024 • edited Loading

Choose a reason for hiding this comment

daschuer left a comment

Choose a reason for hiding this comment

daschuer commented Nov 10, 2024

JoergAtGithub commented Nov 11, 2024

daschuer commented Nov 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acolombier commented Oct 19, 2024 •

edited

Loading

daschuer Nov 5, 2024 •

edited

Loading

Swiftb0y Nov 10, 2024 •

edited

Loading