Bug #1128005 - Emphasize the downbeats of a track by a separate marker on the waveform #1529
Conversation
|
just a few works about my experiences with using something similar: 4 measures per phrase works quite well for many tracks, but there are a surprising number of them where the scheme shifts by 2 measures somewhere in the middle. quite irritating, when you're mixing. |
|
You are 100% right, this mirrors my experience as well. However, with this one, I'd like to take more gradual approach first (with the simples steps outlined in the overview). Hopefully at some point we can introduce multiple "beat cues" that can also be used for: |
| @@ -14,6 +14,11 @@ | |||
| WaveformRenderBeat::WaveformRenderBeat(WaveformWidgetRenderer* waveformWidgetRenderer) | |||
| : WaveformRendererAbstract(waveformWidgetRenderer) { | |||
| m_beats.resize(128); | |||
|
|
|||
| // TODO(ntmusic): Read from settings | |||
| m_measureSize = 4; | |||
There was a problem hiding this comment.
This cannot be a settings option, since this varies by tracks and also inside tracks.
|
|
||
| // TODO(ntmusic): Read from settings | ||
| m_measureSize = 4; | ||
| m_phraseSize = 16; |
There was a problem hiding this comment.
The same here, this should be read from the beatgrid itself. It cannot be a fixed value.
The input of these values into the beatgrid can follow these fixed width by default.
| // TODO(ntmusic): Read from settings | ||
| m_measureSize = 4; | ||
| m_phraseSize = 16; | ||
| m_phraseColor.setRgb(255,0,0); |
There was a problem hiding this comment.
This need to be one a skin option.
Skins can already colour the waveforms.
| @@ -67,8 +72,7 @@ void WaveformRenderBeat::draw(QPainter* painter, QPaintEvent* /*event*/) { | |||
| painter->setRenderHint(QPainter::Antialiasing); | |||
|
|
|||
| QPen beatPen(m_beatColor); | |||
| beatPen.setWidthF(std::max(1.0, scaleFactor())); | |||
| painter->setPen(beatPen); | |||
| beatPen.setWidthF(std::max(0.5, scaleFactor())); | |||
There was a problem hiding this comment.
Can we see a all beat markers at 50 % with a halve pixel width?
| // If we don't have enough space, double the size. | ||
| if (beatCount >= m_beats.size()) { | ||
| m_beats.resize(m_beats.size() * 2); | ||
| } | ||
|
|
||
| if(beatIndex >= 0) { |
There was a problem hiding this comment.
This logic needs to be moved at least to the
Iterator.
I suggest a isBar() and isPhraseStart()
A phrase does not necessarily strat with a bar.
|
I use Mixxx mainly for funk & disco, you'd be surprised how many weird things go on in these tracks. This is a really nice idea but definitely needs more work. Good job so far. Even if it was something like "section markers", or just various types of markers other than Cues, that might be helpful! |
|
The requested changes are quite easy to add, however I am starting to think we should have Time Signature (2/4, 3/4, 4/4, etc.) added as part of the Track class first. |
|
Yes, right, this should be available in the library column as well. Be aware that we will have the same issue like BPM and key: We can only show one significant (the first?) value in the library, while the actual value may change during the track. |
|
Matroska has a MEASURE Tag: https://matroska.org/technical/specs/tagging/index.html |
|
A follow up PR is this #1918 |
|
I am closing this because the original PR author has deleted their GitHub account and someone else is actively working on this now in #1918. |
This PR attempts a simple solution to bug #1128005. It introduces measure (downbeat, every 4 beats) and phrase (16 beats) markers as part of the Waveform view. The location of these markers will eventually be determined by the Cue or a new Cue type, especially designated for beat grid anchoring. The main purpose of this feature is to facilitate better beat-matching.
The implementation plan for this feature is: