Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allen & Heath Xone K2/K1 mapping part 2 #1554

Merged
merged 8 commits into from
Apr 3, 2018
Merged

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Mar 23, 2018

I realized I could fit in the loop_in and loop_out Controls for manual loops with the supershift mode. This works well because these Controls don't require showing any state on the LEDs.

Be-ing added 2 commits March 18, 2018 13:05
loop_in & loop_out do not require showing any state on the LEDs, so
they work well for supershift mode.
@Be-ing Be-ing added this to the 2.1.0 milestone Mar 23, 2018
accessed by pressing the Layer button of the 4 effect unit layouts
@Be-ing Be-ing changed the title Allen & Heath Xone K2 mapping tweaks Allen & Heath Xone K2/K1 part 2 Mar 25, 2018
@Be-ing Be-ing changed the title Allen & Heath Xone K2/K1 part 2 Allen & Heath Xone K2/K1 mapping part 2 Mar 25, 2018
@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 25, 2018

I have added a new mode that allows for controlling the parameters of all the effects in one unit at a time. It is only available in the 4 effect unit layouts and is activated with the Layer button in the bottom left. Documentation is on the wiki.

Copy link
Contributor

@ferranpujolcamins ferranpujolcamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your new mode is nice! However, I miss the possibility to change effects without having to exit the focused mode.

@@ -424,6 +427,9 @@ XoneK2.Deck = function (column, deckNumber, midiChannel) {
shift: function () {
this.inKey = 'beatlooproll_activate';
},
supershift: function () {
this.inKey = 'loop_out';
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pending to be documented in the wiki, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documented

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 26, 2018

I miss the possibility to change effects without having to exit the focused mode.

I thought about that but I am not sure where to fit it into the design. Maybe shift + the first parameter knob?

@ferranpujolcamins
Copy link
Contributor

You could map each parameter knob

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 26, 2018

That happens to make the code a little simpler, so I'll do that.

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 26, 2018

Now that I have implemented this new mode, I am really looking forward to a GSOC student implementing parameter rearrangement this summer. It would be cool to make that somehow mappable for controllers, for example maybe a new ControlObject to cycle the last parameter to the first parameter position. I'll have to think about this more...

Be-ing added 3 commits March 26, 2018 16:26
... that do not have a way to query the controller on startup for the
position of all the knobs.
when a single effect unit is focused. Any of the knobs for the effect
parameters can be used.
These replace the deck 3 & 4 buttons for 2 deck layouts. For the 4
effect unit layouts, the master and headphone routing buttons are
accessible with shift.
@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 26, 2018

Okay, I implemented effect switching by turning any parameter knob with shift in the effect unit focused mode.

I changed the 2 deck + 2 effect unit layouts so the bottom two effect routing buttons control the routing for the master and headphone channels. I don't think there's a point to having those mapped for routing to decks 3 and 4 when those decks are not mapped on the controller. Also, with the 4 effect unit layout, the deck 3 & 4 routing buttons switch to controlling the master and headphones channels with shift and turn amber instead of red.

I'm thinking about switching the shifted and unshifted functions of the bottom two amber buttons for the decks in loop mode. That is, they'd do beatjumping normally and loop double/halve with shift. What do you think about that?

@ferranpujolcamins
Copy link
Contributor

I'm thinking about switching the shifted and unshifted functions of the bottom two amber buttons for the decks in loop mode. That is, they'd do beatjumping normally and loop double/halve with shift. What do you think about that?

I don't have a strong preference about that. What you prefer will be ok :)

About your last changes, I won't be able to test them soon.

In my experience accessing beatjumping quickly is more important
than quickly adjusting the loop size.
@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 30, 2018

@ferranpujolcamins can you do one last check to make sure nothing is obviously messed up?

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 31, 2018

I just played a set with this for a few hours. I am quite happy with the decision to make beatjumping the default action of the bottom buttons instead of loop halve/double. It is very useful on a controller without jog wheels.

@Be-ing Be-ing merged commit 5fc314e into mixxxdj:master Apr 3, 2018
ronso0 added a commit to ronso0/mixxx that referenced this pull request Jul 19, 2018
Allen & Heath Xone K2/K1 mapping part 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants