Update American Audio VMS4 preset for Mixxx v2.1.x #1669

Pegasus-RPG · 2018-05-17T14:19:38Z

Add cue-play function on shifted CUE buttons (to match Traktor Edition label)
Add sync_master on shifted PLAY buttons (to match Traktor Edition label)
Update reloop buttons to use reloop_toggle
Make effect controls operate on UnitN_EffectM, correcting behavior
Add library pane scrolling to touch strips
Add effects dry/wet control to shifted touch strips (to match Traktor Edition labels), replaces needle-drop functionality
Replace setValue() with setParameter() on effect parameter controls
Update version numbers

- Update Mixxx version - Add cue_play on shifted CUE buttons (to match Traktor Edition label) - Add sync_master on shifted PLAY buttons (to match Traktor Edition label) - Update reloop buttons to use reloop_toggle - Make effect controls operate on Unit1_EffectM, correcting behavior

- Change CUP button to use cue_gotoandplay - Add strip scroll and touch functions that make the absolute-position touch scripts behave like relative-mode ones for scrolling through the library - Comment-out needle drop function in preparation for replacing it with effect dry/wet - Update script version and date

- Add effects dry/wet control to shifted touch strips - Replace setValue() with setParameter() - Delete now-unneeded strip touch button down if branch

Pegasus-RPG · 2018-05-17T15:39:09Z

Wiki page updated. https://mixxx.org/wiki/doku.php/american_audio_vms4

daschuer

Who wants to review this? Or can we just merge as it is. This is the last mandatory 2.1 PR

Be-ing · 2018-05-19T22:36:35Z

res/controllers/American Audio VMS4.midi.xml

         </control>
         <control><!-- Shifted Play -->
            <group>[Channel1]</group>
-            <key>start_play</key>
+            <key>sync_master</key>


Why is this mapped? @ywwg why does this Control exist? Should we remove it to avoid future confusion?

I mapped as many things from the Traktor Edition of the VMS4 to the standard one that did not conflict with how the standard one is labeled. This is one of those items.

AFAIK this Control was made while developing master sync but it was decided not to expose it to users.

It's on the MixxxControls wiki page. @ywwg what say you?

Be-ing · 2018-05-19T22:40:11Z

res/controllers/American-Audio-VMS4-scripts.js

-        engine.setValue("[EffectRack1_EffectUnit"+deckNum+"]","enabled",
-                        !engine.getValue("[EffectRack1_EffectUnit"+deckNum+"]","enabled")
+        engine.setValue("[EffectRack1_EffectUnit"+deckNum+"_Effect1]","enabled",
+                        !engine.getValue("[EffectRack1_EffectUnit"+deckNum+"_Effect1]","enabled")


Use the script.toggleControl shorthand

Cool, didn't know that existed. I guess I need to re-read the whole controller scripting page sometime. :)

Be-ing · 2018-05-19T22:41:41Z

res/controllers/American Audio VMS4.midi.xml

@@ -922,6 +934,18 @@
            <status>0x80</status>
            <midino>0x2E</midino>
         </control>
+         <control><!-- on -->
+            <group>[Channel2]</group>
+            <key>cue_play</key>


Personally I think it's most useful to map shift + cue to start_stop, but I guess this works 🤷‍♂️

Be-ing · 2018-05-19T22:45:03Z

res/controllers/American Audio VMS4.midi.xml

@@ -270,13 +271,13 @@
         </control>
         <control><!-- on -->
            <group>[Channel1]</group>
-            <key>cue_play</key>
+            <key>cue_gotoandplay</key>


This is redundant with holding down the cue button then pressing play. I think it would be more useful to use start_stop here.

Be-ing · 2018-05-19T22:54:17Z

res/controllers/American-Audio-VMS4-scripts.js

+
+VMS4.strip_scroll = function(channel, control, value, status, group) {
+    var side = VMS4.StripToSide[control];
+    if (VMS4.touchStripPos[side] != null) {


I'll fix that. (What's the difference again?)

!= can easily introduce confusing bugs because of JS' bizarre type coercion rules.

Be-ing · 2018-05-19T22:59:10Z

I'm confused why you are removing the useful touch strip seeking functionality ("strip search") to add a redundant way to control the dry/wet knob of effect units.

Can you update this to use the Components EffectUnit?

Pegasus-RPG · 2018-05-20T05:53:58Z

Same thing, the Traktor Edition uses the touch strips to control that. Since they're multi-touch strips, you can do some neat things with them like touching and holding in one place, then tapping in another to rhythmically change the effect a la the Stanton SCS.3d. I can add an option at the top of the script that lets the user choose needle dropping or FX D/W.

Pegasus-RPG · 2018-05-20T05:58:34Z

As for Components, there are only two knobs and two buttons (per side) that control effects on the standard edition so I understand that wouldn't be a good fit, but it will for the Traktor Edition, which I'm still working on creating a mapping overlay for.

Be-ing · 2018-05-20T20:42:02Z

How do you intend to handle that? Will you make a duplicate mapping or boolean option at the top of the script?

Pegasus-RPG · 2018-05-21T15:26:49Z

Separate XML file, stub script loaded first that sets a variable VMS4.edition that the main script checks and changes behavior accordingly.

daschuer · 2018-05-23T22:54:50Z

This is the last one for Mixxx 2.1.1. Is it ready to merge now?

daschuer · 2018-05-24T21:04:42Z

@Be-ing: What do you think is this worth to delay 2.1.1 or is it merge-able anyway?

Be-ing · 2018-05-24T22:51:06Z

This could be merged if the track seeking with shift+touch strip is restored. IMO there's no need to delay 2.1.1 for this PR.

Pegasus-RPG · 2018-05-25T01:58:16Z

@Be-ing It is. See the latest commit.

Be-ing · 2018-05-25T02:25:56Z

Oh sorry, somehow I missed that commit before.

Pegasus-RPG added 4 commits May 17, 2018 07:12

AA VMS4: Fix touch strip needle drop scale

dd9af16

AA VMS4 preset update - touch strip FX

00dc810

- Add effects dry/wet control to shifted touch strips - Replace setValue() with setParameter() - Delete now-unneeded strip touch button down if branch

daschuer added this to the 2.1.1 milestone May 17, 2018

daschuer reviewed May 19, 2018

View reviewed changes

daschuer added the controller mappings label May 19, 2018

Be-ing reviewed May 19, 2018

View reviewed changes

Pegasus-RPG added 2 commits May 21, 2018 08:28

Address code review notes.

89c9511

Add needle drop when deck isn't playing, FX dry/wet when it is.

715548f

Be-ing merged commit 5fe3902 into mixxxdj:2.1 May 25, 2018

Pegasus-RPG deleted the vms4 branch November 22, 2018 02:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update American Audio VMS4 preset for Mixxx v2.1.x #1669

Update American Audio VMS4 preset for Mixxx v2.1.x #1669

Pegasus-RPG commented May 17, 2018 •

edited

Loading

Pegasus-RPG commented May 17, 2018

daschuer left a comment

Be-ing May 19, 2018

Pegasus-RPG May 20, 2018 •

edited

Loading

Be-ing May 20, 2018

Pegasus-RPG May 21, 2018

Be-ing May 19, 2018

Pegasus-RPG May 20, 2018

Be-ing May 19, 2018

Be-ing May 19, 2018

Be-ing May 19, 2018

Pegasus-RPG May 20, 2018

Be-ing May 20, 2018

Be-ing commented May 19, 2018

Pegasus-RPG commented May 20, 2018 •

edited

Loading

Pegasus-RPG commented May 20, 2018 •

edited

Loading

Be-ing commented May 20, 2018

Pegasus-RPG commented May 21, 2018

daschuer commented May 23, 2018

daschuer commented May 24, 2018

Be-ing commented May 24, 2018

Pegasus-RPG commented May 25, 2018

Be-ing commented May 25, 2018 •

edited

Loading

Update American Audio VMS4 preset for Mixxx v2.1.x #1669

Update American Audio VMS4 preset for Mixxx v2.1.x #1669

Conversation

Pegasus-RPG commented May 17, 2018 • edited Loading

Pegasus-RPG commented May 17, 2018

daschuer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pegasus-RPG May 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Be-ing commented May 19, 2018

Pegasus-RPG commented May 20, 2018 • edited Loading

Pegasus-RPG commented May 20, 2018 • edited Loading

Be-ing commented May 20, 2018

Pegasus-RPG commented May 21, 2018

daschuer commented May 23, 2018

daschuer commented May 24, 2018

Be-ing commented May 24, 2018

Pegasus-RPG commented May 25, 2018

Be-ing commented May 25, 2018 • edited Loading

Pegasus-RPG commented May 17, 2018 •

edited

Loading

Pegasus-RPG May 20, 2018 •

edited

Loading

Pegasus-RPG commented May 20, 2018 •

edited

Loading

Pegasus-RPG commented May 20, 2018 •

edited

Loading

Be-ing commented May 25, 2018 •

edited

Loading