Lib redesign skin fixes #1671

ronso0 · 2018-05-19T13:02:01Z

Edit I removed the feature label from the sidebar in all skins. The feature title is available via BreadCrumbs above tracks table.

Tango:

move BreadCrumbs back above tracks table
style AutoDJ spinbox like beatsize spinboxes
fix minor issues

Deere: move Lib maximize toggle above WButtonbar, push it next to Searchbox if sidebar is (almost) collapsed

LateNight:

fix feature button bar style
fix feature buttons & feature backgrounds
style AutoDJ spinbox like beatsize spinboxes
add translucent scrollbar handles to sidebar
redesign toolbar divider to differ from splitter handle

Please test!

Be-ing · 2018-05-19T16:04:19Z

screenshots?

ronso0 · 2018-05-19T16:31:23Z

screens added

Be-ing

The text above the control pane in LateNight is cut off for me with Qt5 and a scale factor of 2.5.

Interestingly the feature name text above the track table does not show at all in Tango:

While we have only one feature showing, I think this is preferable. If you could make the other skins do this, that would be nice.

Aside from that I noticed some minor code quality nitpicks.

Be-ing · 2018-05-19T21:46:47Z

res/skins/Deere/library_sidebar_tester.xml

+-->
+<Template>
+  <WidgetGroup>
+    <ObjectName>TEST2</ObjectName>


Did you forget to remove this line?

Be-ing · 2018-05-19T21:47:00Z

res/skins/Deere/library_sidebar_tester.xml

+  a) If the library sidebar is big enough they are shown above the tree view.
+  b) If the sidebar is too narrow, they are shown above the tracks table,
+     next to the searchbox 
+  Depending on sidebar size, the WidgetStacks flip '[Tango],lib_sidebar_collapsed'


Be-ing · 2018-05-19T21:47:17Z

res/skins/Deere/library.xml

            <Children>
+
+              <Template src="skin:library_sidebar_tester.xml"/>


I can name it library_sidebar_width_detector.xml

or we move the button bar outside the splitter, then this SizeAwareStack can be removed as well

Be-ing · 2018-05-19T21:48:29Z

res/skins/LateNight/library.xml

+                      </WidgetGroup>
+
+                      <Splitter>
+                        <ObjectName>HoriSplitter</ObjectName>


Please spell out "HorizontalSplitter"

Be-ing · 2018-05-19T21:49:16Z

res/skins/LateNight/library.xml

        <Layout>horizontal</Layout>
        <SizePolicy>me,me</SizePolicy>
        <Children>

          <Splitter>
-            <ObjectName>LibrarySplitter</ObjectName>
+            <ObjectName>VertSplitter</ObjectName>


Please spell out "VerticalSplitter"

Be-ing · 2018-05-19T21:50:42Z

res/skins/Tango/library_sidebar_tester.xml

+  a) If the library sidebar is big enough they are shown above the tree view.
+  b) If the sidebar is too narrow, they are shown above the tracks table,
+     next to the searchbox 
+  Depending on sidebar size, the WidgetStacks flip '[Tango],lib_sidebar_collapsed'


[Tango]? Do you mean [Skin]?

… pane etc.

…button margins

ronso0 · 2018-05-21T00:12:31Z

The text above the control pane in LateNight is cut off for me with Qt5 and a scale factor of 2.5.

yep, I used a different hack to hide it. works @100% but scaling doesn't respect all sizes declared in css. Changed it so it works like in Tango now.

While we have only one feature showing, I think this is preferable. If you could make the other skins do this, that would be nice.

Sure. Also applied some basic fixes in Shade.
@daschuer Do you plan to update the Shade library styling? Apart from the feature icons it looks like qt default.

…litters in LateNight

…ins"

ronso0 · 2018-06-14T11:25:32Z

@Be-ing
Conflicts are resolved and the library is laid out the same way in all skins now.
Please test.

ronso0 · 2018-06-14T11:40:32Z

Though I'm wondering why the Library preview button in LateNight has some kind of minimum width defined: the preview column can be resized but the button itself occupies 65px anyway, so the icon is shifted and only partially visible if the preview column is too small

nopeppermint · 2018-06-16T11:43:04Z

in latenight if you disable "show text in sidebar icon" it doesn't rescale automatically, you need to change the window size for this..

the bpm "locked" is somehow broken:

nopeppermint · 2018-06-16T11:44:59Z

Shade Autodj Fade time is almost invisible

nopeppermint · 2018-06-16T11:51:31Z

library styling for latenight is somehow broken:
compared to 2.1

hover for preview button is extended over his column and the played checkbox locks better in 2.1

nopeppermint · 2018-06-16T12:00:48Z

Deere preview button is broken

ronso0 · 2018-06-17T15:55:26Z

Deere preview button is broken

Strange, didn't touch it. Fixed.

I'm wondering why the Library preview button in LateNight has some kind of minimum width

Got it! It was a leftover/merge conflict:

WBaseLibrary QPushButton {
  min-width: 65px;
  min-height: 22px;
  max-height: 22px;

in latenight if you disable "show text in sidebar icon" it doesn't rescale automatically

Can't confirm, behaves basicallly the same in all skins.
Though I can't test with most recent lib-redesign branch because I messd up my qt souces somehow..

Shade Autodj Fade time is almost invisible

Those special library features are still unstyled as I was waiting for some feedback from @daschuer
So it's the OS them issue again. I'll take care of that and the feature buttons soonish

…olor themes

ronso0 · 2018-06-19T11:39:35Z

Now Shade library is styled as well.
Please test

nopeppermint · 2018-06-19T20:15:56Z

it seems that there are now "Conflicting files"

nopeppermint · 2018-06-19T20:31:16Z

latenight:
fixed:

played checkbox
bpm "locked"

still open:

hover for preview button is extended over his column

And I got a crash while I was trying to load a random track to autodj

Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Warning [Main]: Could not load random track.
Segmentation fault

as Autodj source I had an empty crate, but I was not able to reproduce this crash..

nopeppermint · 2018-06-19T20:36:32Z

fixed:

Deere preview button

Though I can't test with most recent lib-redesign branch because I messd up my qt souces somehow..

I just compiled your branch, or should I compile the lib-redesign branch and copy only the skin folder from your branch?

ronso0 · 2018-06-20T09:21:01Z

it seems that there are now "Conflicting files"

Fixed..again. @Be-ing @daschuer Please review and merge this so I don't need to fix the merge conflicts (Edit and screwed up styles introduced by auto-merge) again.
Any further issues can be fixed in a follow-up PR

ronso0 · 2018-06-20T09:22:25Z

And I got a crash while I was trying to load a random track to autodj

Not related to this PR as it changes skin files only.
Please post those issues to lib-redesign branch or to respective zulip chat.

ronso0 · 2018-06-20T10:26:03Z

Screen shots:

ronso0 · 2018-06-20T10:28:51Z

@nopeppermint
Due to the conflicts I just rebased to jmigual-lib-redesign, so it shouldn't make any difference which branch you compile as long as you use the skins from here.

nopeppermint · 2018-06-20T22:07:16Z

@ronso0 nice !
there might be more minor fix but in general it looks good on all skins under Linux Mint x64

one thing I see compared with branch 2.1, the title of the currently selected widget (library, autodj... ) needs a lot of vertical space.

I think one's the suggested layout in #1117 (comment) is implemented, we need less space as well

Single library after first start: search box next to bread crumbs (goes below if table width gets too small to show both side by side))

Be-ing · 2018-06-23T13:36:20Z

There are still some small issues, but those can be fixed later. This branch has enough improvements to be merged now. Thanks @ronso0, and thanks @nopeppermint for review.

Be-ing · 2018-06-23T13:45:26Z

Minor issues in Tango:

The cover art toggle icon feels out of place and IMO wastes space. Couldn't it be moved to the skin settings menu? None of the other skins have it by the feature buttons.
Although I can use the splitter between the control pane and track table, I don't see it so it would be difficult to discover if I was not looking for it.

ronso0 · 2018-06-24T13:01:08Z

The cover art toggle icon feels out of place and IMO wastes space

yeah, this can be removed. I notice I don't use it at all anymore. It was intended as a quick toggle instead of going to the View menu, so IMO it doesn't make sense to have it in Skin Settings.

The splitter graphic shows up when I load now-merged & updated Tango from lib-redesign branch. There were issues after rebasing but it should be fine now.

ronso0 · 2018-06-24T13:18:13Z

follow-up is #1723

ronso0 added 7 commits May 18, 2018 23:50

lib-redesign Deere: move Lib expand toggle above sidebar buttons

1c31d7d

lib-redesign LateNight: fix Library styling

f08c2ca

lib-redesign LateNight: add CO for Lib icon text to skin.xml

4b978c3

lib-redesign Tango: fix & comment Library styling

b0627dd

lib-redesign LateNight: fix inactive library buttons

c4a7b5c

lib-redesign LateNight: add Id to LibrarySidebarButtons

a284bf0

lib-redesign LateNight: small UX tweaks

0f820c3

LateNight/Tango: tweak library sort buttons

22e4fc0

Be-ing suggested changes May 19, 2018

View reviewed changes

ronso0 added 12 commits May 20, 2018 21:37

lib-redesign Deere: hide feature label

4dd9849

lib-redesign Deere: fix library feature top margin

983e208

lib-redesign Deere: style AutoDJ transition time like beatsize spinboxes

2b5ec51

lib-redesign Deere: emphasize tab buttons in library feature

4824f42

lib-redesign LateNight: properly hide the feature label

8b3d5f7

lib-redesign LateNight: style feature tab header buttons

265b248

lib-redesign LateNight: style buttons, remove double border in AutoDJ…

4fa873e

… pane etc.

lib-redesign Deere: revert Feature label hack for recording feature

5690baf

lib-redesign Tango: make Analysis radio buttons smaller

3c264c2

lib-redesign Tango: style AutoDJ spinbox like beatsize spinboxes

f13eca8

lib-redesign Tango: clean up

a2b0477

lib-redesign Shade: remove label above feature pane, remove old QPush…

c659ddb

…button margins

lib-redesign: clean up code, rename lib sidebar width detector and sp…

2b06492

…litters in LateNight

ronso0 pushed a commit to ronso0/mixxx that referenced this pull request May 21, 2018

LateNight: backport of Library styling from mixxxdj#1671

8c38fea

ronso0 mentioned this pull request May 21, 2018

Library improvements for all skins, fix lp:1772202 in Tango #1677

Merged

ronso0 changed the title ~~Lib redesign skin fixes~~ [WIP] Lib redesign skin fixes May 21, 2018

lib-redesign Tango: move Breadcrumbs above searchbox like in other sk…

d46c33c

…ins"

nopeppermint mentioned this pull request May 22, 2018

WIP: add a fixed autodj tab to the library #1681

Closed

lib-redesign skins: allow to toggle Library button text in all skins

680a701

ronso0 added 2 commits June 17, 2018 17:57

lib-redesign skins: small fixes

682f0c8

lib-redesign Shade: style Library features like rest of skin, incl. c…

86fc0f3

…olor themes

merge jmigual-library-redesign, fix conflicts again

330d364

lib-redesign skins: fix regressions introduced by git auto-merge

41115f2

lib-redesign-skins: fix Splitter regressions

2b0a466

ronso0 mentioned this pull request Jun 23, 2018

library redesign: fix crash right clicking empty area of AutoDJ crates pane #1720

Merged

Be-ing changed the title ~~[WIP] Lib redesign skin fixes~~ Lib redesign skin fixes Jun 23, 2018

Be-ing merged commit 1ede6dd into mixxxdj:jmigual-library-redesign Jun 23, 2018

ronso0 deleted the lib-redesign-skin-fixes branch June 24, 2018 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lib redesign skin fixes #1671

Lib redesign skin fixes #1671

ronso0 commented May 19, 2018 •

edited

Loading

Be-ing commented May 19, 2018

ronso0 commented May 19, 2018

Be-ing left a comment •

edited

Loading

Be-ing May 19, 2018

Be-ing May 19, 2018

Be-ing May 19, 2018

ronso0 May 20, 2018

ronso0 May 21, 2018

Be-ing May 19, 2018

Be-ing May 19, 2018

Be-ing May 19, 2018

ronso0 commented May 21, 2018

ronso0 commented Jun 14, 2018

ronso0 commented Jun 14, 2018

nopeppermint commented Jun 16, 2018

nopeppermint commented Jun 16, 2018

nopeppermint commented Jun 16, 2018 •

edited

Loading

nopeppermint commented Jun 16, 2018

ronso0 commented Jun 17, 2018

ronso0 commented Jun 19, 2018

nopeppermint commented Jun 19, 2018

nopeppermint commented Jun 19, 2018 •

edited

Loading

nopeppermint commented Jun 19, 2018

ronso0 commented Jun 20, 2018 •

edited

Loading

ronso0 commented Jun 20, 2018

ronso0 commented Jun 20, 2018

ronso0 commented Jun 20, 2018 •

edited

Loading

nopeppermint commented Jun 20, 2018

Be-ing commented Jun 23, 2018

Be-ing commented Jun 23, 2018 •

edited

Loading

ronso0 commented Jun 24, 2018

ronso0 commented Jun 24, 2018

Lib redesign skin fixes #1671

Lib redesign skin fixes #1671

Conversation

ronso0 commented May 19, 2018 • edited Loading

Be-ing commented May 19, 2018

ronso0 commented May 19, 2018

Be-ing left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ronso0 commented May 21, 2018

ronso0 commented Jun 14, 2018

ronso0 commented Jun 14, 2018

nopeppermint commented Jun 16, 2018

nopeppermint commented Jun 16, 2018

nopeppermint commented Jun 16, 2018 • edited Loading

nopeppermint commented Jun 16, 2018

ronso0 commented Jun 17, 2018

ronso0 commented Jun 19, 2018

nopeppermint commented Jun 19, 2018

nopeppermint commented Jun 19, 2018 • edited Loading

nopeppermint commented Jun 19, 2018

ronso0 commented Jun 20, 2018 • edited Loading

ronso0 commented Jun 20, 2018

ronso0 commented Jun 20, 2018

ronso0 commented Jun 20, 2018 • edited Loading

nopeppermint commented Jun 20, 2018

Be-ing commented Jun 23, 2018

Be-ing commented Jun 23, 2018 • edited Loading

ronso0 commented Jun 24, 2018

ronso0 commented Jun 24, 2018

ronso0 commented May 19, 2018 •

edited

Loading

Be-ing left a comment •

edited

Loading

nopeppermint commented Jun 16, 2018 •

edited

Loading

nopeppermint commented Jun 19, 2018 •

edited

Loading

ronso0 commented Jun 20, 2018 •

edited

Loading

ronso0 commented Jun 20, 2018 •

edited

Loading

Be-ing commented Jun 23, 2018 •

edited

Loading