Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LV2 packaging fixes #1672

Merged
merged 3 commits into from
May 27, 2018
Merged

LV2 packaging fixes #1672

merged 3 commits into from
May 27, 2018

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented May 19, 2018

see commit messages

@rryan
Copy link
Member

rryan commented May 19, 2018

lgtm

@Be-ing
fix build with lilv=0
925aa1e 
for macOS and Windows
@Be-ing Be-ing force-pushed the lv2_build_option branch from 4fe3ca6 to 852a7f5 Compare May 19, 2018 18:51
@Be-ing
Copy link
Contributor Author

Be-ing commented May 19, 2018

@daschuer could you take a look at this?

@Be-ing Be-ing added the effects label May 20, 2018
@Be-ing Be-ing added this to the 2.2.0 milestone May 20, 2018
@Be-ing Be-ing force-pushed the lv2_build_option branch from 852a7f5 to 76bbf09 Compare May 22, 2018 12:31
@Be-ing
Copy link
Contributor Author

Be-ing commented May 24, 2018

@daschuer ready for merge?

@daschuer
Copy link
Member

LGTM, and works good.
With this being merged, we can IMHO merge the LV2 branch to master.

@Be-ing
Copy link
Contributor Author

Be-ing commented May 27, 2018

Thank you for review. We have a segfault to fix before we can merge the LV2 branch to master.

@Be-ing Be-ing merged commit 9a6c13c into mixxxdj:lv2_support2 May 27, 2018
@daschuer
Copy link
Member

Ok, Ubuntu Travis build seems to fail unrelated. Mac Os fails because of missing liliv. So it should be save for merging.

@Be-ing
Copy link
Contributor Author

Be-ing commented May 27, 2018 •
edited
Loading

We also need to finish #1674 before merging the LV2 branch to master.

ronso0 added a commit to ronso0/mixxx that referenced this pull request Jul 19, 2018
@ronso0
Merge pull request mixxxdj#1672 from Be-ing/lv2_build_option
b7982f1 
LV2 packaging fixes
@Be-ing Be-ing deleted the lv2_build_option branch April 24, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @rryan @daschuer