OS Theme shining though fix

[daschuer]

This fixes https://bugs.launchpad.net/mixxx/+bug/1773709, and should help in
#1687
and
#1677

[ronso0]

Thanks, it works!

[daschuer]

I have cleaned up the solution a bit.
Who can help with test and review?

[nopeppermint]

still working, no OS theme shining though, but I now get more frequently this behavior:
two orange play buttons...

[ronso0]

still working, no OS theme shining though, but I now get more frequently this behavior:
two orange play buttons...

I can see the previously activated preview button light up shortly when I hit another preview button.
But I noticed it before those changes.

[nopeppermint]

button light up shortly

it's not shortly, it's persistent..

[nopeppermint]

and I do not have this on #1687

[nopeppermint]

button light up shortly

it's not shortly, it's persistent..

prober rebuild fixed everything ..

[ronso0]

@daschuer Before merging this, I think it's better to reset to d386676 to avoid conflicts in #1677

[nopeppermint]

BTW:
there is more OS Theme shining through if you edit in the library:

but in the bpm folder it's already fixed

[ronso0]

there is more OS Theme shining through if you edit in the library

I tried QTableView::item:edit-focus but that didn't work.

[daschuer]

OK, rebased, to get rid of merge conflicts.
Does anyone likes to do a code review.
I like to release 2.1 soon, and it would be a pity if this will not be included.

[uklotzde]

These lines are duplicated in TableItemDelegate::paint(). Can we move them into a protected utility function in the base class?

[uklotzde]

I'm not a UI expert, but the changes look fine so far. Code quality has been improved. Only a small amount of code duplication that could be avoided. I will test this now.

[uklotzde]

Here is a first screenshots from an inofficial Qt5 build. Later I will switch back to the Qt4 build and test again.

When selecting a BPM cell the value becomes invisible:

This worked correctly before applying these changes.

[nopeppermint]

@uklotzde

When selecting a BPM cell the value becomes invisible:

In my opinion you need as well those UI changes from #1677

[uklotzde]

On Qt4 I don't even notice any visual differences in Deere (all previous changes included). My only complaint is the small amount of duplicated code.

[daschuer]

Good catch, it was not only duplicated code It was redundant code. I have probably failed to remove it after moving the code.

[daschuer]

@uklotzde: ready for merge?

[uklotzde]

Windows build failures seem to be unrelated.

I did not notice the bugs in my personal setup and configuration, but I trust the other reviewers that the original issues have been fixed. The code improvements are some welcome added value.

LGTM.