Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundtouch 2.0 #1706

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Soundtouch 2.0 #1706

merged 1 commit into from
Jun 10, 2018

Conversation

daschuer
Copy link
Member

As discussed in https://bugs.launchpad.net/mixxx/+bug/1577042 we fall back to Soundtouch 2.0 in our own source tree until the distros have updated their versions as well.
This has already happen in Ubuntu Trusty which has soundtouch 1.7 and we require 1.8

@daschuer daschuer added this to the 2.1.1 milestone Jun 10, 2018
@daschuer
Copy link
Member Author

This is the last one for 2.1.1 I guess.

@Be-ing
Copy link
Contributor

Be-ing commented Jun 10, 2018

I do not think we should ship different versions of dependencies from what distributions already provide. Doesn't this violate distributions' packaging rules? Also, it is not fair to give the Debian multimedia maintainers merely 2 days to respond to us.

@daschuer
Copy link
Member Author

I do not see a problem at all here.
We only require Soundtouch 2.0 here to make Mixxx not crashing, our main responsibility.
The code works now in a way that the Debian maintainer have any time to fix the issues upstream. Once they are ready the code compiles aromatically again with the system provided library. This is the same we did for Trusty and the 1.7 crash.
In our own PPA there is no need to follow a packing rule if it results into a crashing build.

@Be-ing
Copy link
Contributor

Be-ing commented Jun 10, 2018

Ah okay, thank you for explaining. So this will make it so the Debian maintainers have to update their Soundtouch package if they want to package Mixxx 2.1.1. LGTM then.

@Be-ing Be-ing merged commit 4302cd0 into mixxxdj:2.1 Jun 10, 2018
@daschuer daschuer deleted the soundtouch20 branch September 7, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants