Odd behaviour of libz decoding of cover_default.png at TracksTreeMode… #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l::addCoverArt bypassed by using the SVG version
Be-ing
suggested changes
Jun 11, 2018
res/mixxx.qrc
Outdated
| @@ -3,6 +3,7 @@ | |||
| <file>../LICENSE</file> | |||
| <file>images/ic_mixxx_window.png</file> | |||
| <file>images/library/cover_default.png</file> | |||
There was a problem hiding this comment.
remove the PNG image here and delete the PNG file
res/mixxx.qrc
Outdated
| @@ -3,6 +3,7 @@ | |||
| <file>../LICENSE</file> | |||
| <file>images/ic_mixxx_window.png</file> | |||
| <file>images/library/cover_default.png</file> | |||
| <file>images/templates/cover_default.svg</file> | |||
There was a problem hiding this comment.
move this to images/library instead of images/templates
|
Before we can merge your code, please sign the Mixxx Contributor Agreement and comment here when you have. In a nutshell, it allows us to distribute your work under the GPL as well as the Mac App Store which has terms that conflict with the GPL (refer to the link for the full legalese). |
|
Signed. |
|
For the future, please use shorter text for your short commit message. You can explain more details in the rest of the commit message. |
Files and resource config changed.
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l::addCoverArt bypassed by using the SVG version
Using the PNG version, caused the UI/Thread 1 to lock up.